Skip to content

remove verification #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2023
Merged

remove verification #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abce9ee
remove verification
mariasergeenko Dec 5, 2023
adb141c
update link
mariasergeenko Dec 6, 2023
47fbfb9
remove only
mariasergeenko Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/e2e/pageObjects/welcome-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export class WelcomePage extends BasePage {
importCloudDbBtn = Selector('[data-testid=import-cloud-db-btn]');
importDbFromFileBtn = Selector('[data-testid=import-from-file-btn]');
// Links
buildFromSource = Selector('a').withExactText('Build from source');
buildFromLinux = Selector('a').withExactText('Linux');
buildFromDocker = Selector('a').withExactText('Docker');
buildFromHomebrew = Selector('a').withExactText('Homebrew');
// Text
Expand Down
14 changes: 7 additions & 7 deletions tests/e2e/tests/web/smoke/database/add-db-from-welcome-page.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ const databaseAPIRequests = new DatabaseAPIRequests();
const welcomePage = new WelcomePage();

const getPageUrl = ClientFunction(() => window.location.href);
const sourcePage = 'https://developer.redis.com/create/from-source/?utm_source=redis&utm_medium=app&utm_campaign=redisinsight';
const dockerPage = 'https://developer.redis.com/create/docker/?utm_source=redis&utm_medium=app&utm_campaign=redisinsight';
const homebrewPage = 'https://developer.redis.com/create/homebrew/?utm_source=redis&utm_medium=app&utm_campaign=redisinsight';
const promoPage = 'https://redis.com/cloud/overview/?utm_source=redisinsight&utm_medium=main&utm_campaign=main';
const linuxPage = 'https://redis.io/docs/install/install-stack/linux/?utm_source=redisinsight&utm_medium=main&utm_campaign=linux';
const dockerPage = 'https://redis.io/docs/install/install-stack/docker/?utm_source=redisinsight&utm_medium=main&utm_campaign=docker';
const homebrewPage = 'https://redis.io/docs/install/install-stack/mac-os/?utm_source=redisinsight&utm_medium=main&utm_campaign=homebrew';
const promoPage = 'https://redis.com/try-free/?utm_source=redisinsight&utm_medium=main&utm_campaign=main';

fixture `Add database from welcome page`
.meta({ type: 'smoke', rte: rte.standalone })
Expand All @@ -39,9 +39,9 @@ test
});

test('Verify that all the links are valid from Welcome page', async t => {
// Verify build from source link
await t.click(welcomePage.buildFromSource);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this sourcePage verification to Linux?
we have a new link to Linux instead of source page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure,
will do

await t.expect(getPageUrl()).eql(sourcePage, 'Build from source link is not valid');
// Verify linux link
await t.click(welcomePage.buildFromLinux);
await t.expect(getPageUrl()).eql(linuxPage, 'Build for linux link is not valid');
await goBackHistory();
// Verify build from docker link
await t.click(welcomePage.buildFromDocker);
Expand Down