Fe/feature/ri 4989 refactor json data type #3002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-data-type' into fe/feature/RI-4989-refactor-json-data-type
rsergeenko
reviewed
Jan 25, 2024
rsergeenko
reviewed
Jan 25, 2024
| <div className="flex-column" style={{ flex: '1', height: '100%' }}> | ||
| <div | ||
| data-testid="json-details" | ||
| className={`${[styles.container].join(' ')}`} |
There was a problem hiding this comment.
instead of join you should use cx from classnames lib, but here we have only one class
please, review all other places
irinaAbramova-dev
requested review from
ViktarStarastsenka,
egor-zalenski and
ArtemHoruzhenko
as code owners
|
|
rsergeenko
changed the base branch from
feature/RI-4989-refactor-json-data-type
to
main
…r-json_update #RI-4989 - refactor json type
#RI-5574 - fix opening object values fix work with big length json
#RI-5568 - fix editing null value
vlad-dargel
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.