Skip to content

fix regression tests #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix regression tests #3067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41350fe
fix regression tests
mariasergeenko Feb 21, 2024
da62a3f
remove timeout
mariasergeenko Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/e2e/common-actions/workbench-actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ export class WorkbenchActions {
await t.click(workbenchPage.selectViewType)
.click(workbenchPage.viewTypeOptionClientList);
await t.switchToIframe(workbenchPage.iframe);
await t.expect(Selector('tbody tr').count).eql(numberOfRowsInTextView);
const paginationSelector = Selector('a[data-test-subj=pagination-button-next]');
const tableRow = Selector('tbody tr');
let rowCount = await tableRow.count;
if(await paginationSelector.visible) {
await t.click(paginationSelector);
rowCount += await tableRow.count;
}
await t.expect(rowCount).eql(numberOfRowsInTextView);
}
/**
Verify error message after `client list` command if there is no permission to run
Expand Down
3 changes: 1 addition & 2 deletions tests/e2e/tests/web/critical-path/url-handling/url-handling.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ test
memoryLimitMeasurementUnit: 'mb',
free: 'true'
};
console.log('!!!!');
console.log(generateLink(connectUrlParams));

await t.navigateTo(generateLink(connectUrlParams));
await t.wait(10_000);
await t.expect(workbenchPage.submitCommandButton.exists).ok('Redirection to Workbench is not correct');
Expand Down