RI-5150: Added RDI statistics page #3101
Conversation
kyle-marcum
force-pushed
the
fe/feature/RI-5150_statistics-page
branch
3 times, most recently
from
eef18e0 to
d90ca20
Compare
| actions: JSX.Element | ||
| } | ||
|
|
||
| const Header = ({ actions }: Props) => { |
There was a problem hiding this comment.
Can you take a look at this component? RdiPipelineHeader i guess we can combine them in one component
There was a problem hiding this comment.
I will take a look
|
|
||
| useEffect(() => { | ||
| dispatch(fetchRdiPipeline(rdiInstanceId)) | ||
| if (!pipelineData) { |
There was a problem hiding this comment.
Maybe will better move dispatch(fetchRdiPipeline(rdiInstanceId)) to RdiInstancePage ?
| content="My RDI instances" | ||
| <Header | ||
| actions={( | ||
| <EuiOutsideClickDetector onOutsideClick={handleClosePopover}> |
There was a problem hiding this comment.
oh, i see what you did. We need to think about rdi templates (i global template and one for pipeline management)
| } | ||
|
|
||
| useEffect(() => { | ||
| if (!pipelineData) { |
There was a problem hiding this comment.
probably you can move fetch rdi pipeline and fetchConnectedInstanceAction in Instance page and remove it from here and from pipelineMangementPage, what do you think about it?
| <RdiStatisticsHeader /> | ||
| <ExplorePanelTemplate> | ||
| <div className={styles.bodyContainer}> | ||
| {isEmpty(pipelineData) ? ( |
There was a problem hiding this comment.
Do not forget to check this behavior please. We still don't know how will look not deployed pipeline
There was a problem hiding this comment.
I will add a TODO so that we don't forget
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
add blank line, please
|
|
||
| import styles from './styles.module.scss' | ||
|
|
||
| const VerticalDivider = () => ( |
There was a problem hiding this comment.
I'm not sure that we really need it. @romansergeenkosofteq What do you think? i guess we can avoid additional component
There was a problem hiding this comment.
I'm good with using the Divider component directly instead. Just tried to make the usage more succinct.
| import InsightsTrigger from 'uiSrc/components/insights-trigger' | ||
| import Header from 'uiSrc/pages/rdi/components/header' | ||
|
|
||
| const RdiStatisticsHeader = () => <Header actions={<InsightsTrigger source="statistics page" />} /> |
There was a problem hiding this comment.
Maybe better to use ExplorePanelTemplate here? anyway we need to think about templates for rdi pages. But need final mockup for it
There was a problem hiding this comment.
going to remove ExplorePanelTemplate for now since it will be implemented in a later card
kyle-marcum
force-pushed
the
fe/feature/RI-5150_statistics-page
branch
2 times, most recently
from
e9fa82c to
b68e29a
Compare
…page. Removed duplicate statistics svg
… to allow auto refresh to be on by default if desired.
… across pipeline management and statistics pages.
…. Removed Insights button from RDI Statistics page.
…toRefresh component.
kyle-marcum
force-pushed
the
fe/feature/RI-5150_statistics-page
branch
from
607f4bc to
3d55011
Compare
No description provided.