e2e - regression tests #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| async clickOnEditDBByName(databaseName: string): Promise<void>{ |
There was a problem hiding this comment.
Please add a description on top (I see it didn't happen also on functions above)
| }) | ||
| ('Verify that user can connect to DB and see breadcrumbs at the top of the application in Browser page', async t => { | ||
| //Verify that user can see breadcrumbs | ||
| await t.expect(browserPage.breadcrumbsContainer.visible).ok('User can see breadcrumbs in Browser page', { timeout: 20000 }); |
There was a problem hiding this comment.
1 line test? couldn't it be covered over lower levels (such as components)
There was a problem hiding this comment.
another verification is added in this test
| await t.typeText(cliPage.cliCommandInput, command); | ||
| await t.pressKey('enter'); | ||
| //Verify result | ||
| await t.expect(cliPage.cliOutputResponseSuccess.innerText).eql(`"${jsonValue.replace(/"/g, '\\"')}"`, 'The user can see JSON object with escaped quotes'); |
elenaNaboko
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.