Skip to content

#RI-5667 - No scrollbar when editing long value #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2024
Merged

#RI-5667 - No scrollbar when editing long value #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6a9939
* #RI-5667 - No scrollbar when editing long value
egor-zalenski Apr 25, 2024
f1f28b5
* #RI-5667 - No scrollbar when editing long value
egor-zalenski Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ jobs:
macosx:
macos:
xcode: 14.2.0
resource_class: macos.m1.medium.gen1
resource_class: macos.x86.medium.gen2
parameters:
env:
description: Build environment (stage || prod)
Expand Down
2 changes: 1 addition & 1 deletion redisinsight/ui/src/styles/base/_base.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ html {
// sass-lint:disable-block no-misspelled-properties
scrollbar-width: thin;

scrollbar-color: transparent(var(--euiColorDarkShade), 0.5) transparent; // Firefox support
scrollbar-color: var(--scrollBackgroundColor) transparent;
}

body {
Expand Down
33 changes: 32 additions & 1 deletion redisinsight/ui/src/styles/components/_popover.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,42 @@
box-shadow: 0 3px 15px var(--controlsBoxShadowColor) !important;
}

.euiPopover__panel .euiPopover__panelArrow.euiPopover__panelArrow {
border-color: transparent !important;

&--left:before {
border-left-color: var(--euiColorLightShade) !important;
}
&--left:after {
border-left-color: var(--euiColorEmptyShade) !important;
}

&--right:before {
border-right-color: var(--euiColorLightShade) !important;
}
&--right:after {
border-right-color: var(--euiColorEmptyShade) !important;
}

&--bottom:before {
border-bottom-color: var(--euiColorLightShade) !important;
}
&--bottom:after {
border-bottom-color: var(--euiColorEmptyShade) !important;
}

&--top:before {
border-top-color: var(--euiColorLightShade) !important;
}
&--top:after {
border-top-color: var(--euiColorEmptyShade) !important;
}
}

.popoverLikeTooltip {
border: none;
max-width: 267px !important;
background-color: var(--euiTooltipBackgroundColor) !important;

.euiPopover__panelArrow.euiPopover__panelArrow--bottom:after {
border-bottom-color: var(--euiTooltipBackgroundColor) !important;
}
Expand Down
8 changes: 3 additions & 5 deletions redisinsight/ui/src/styles/mixins/_eui.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
$trackBackgroundColor: transparent;

$euiBreakpoints: (
"xs": 0,
"s": 575px,
Expand All @@ -23,14 +21,14 @@ $euiBreakpointKeys: map-keys($euiBreakpoints);
}

&::-webkit-scrollbar-thumb {
background-color: transparent(var(--euiColorDarkShade), .5);
border: 16px Corner solid $trackBackgroundColor;
background-color: var(--scrollBackgroundColor);
border: 6px solid transparent;
background-clip: content-box;
}

&::-webkit-scrollbar-corner,
&::-webkit-scrollbar-track {
background-color: $trackBackgroundColor;
background-color: transparent;
}

@content;
Expand Down
1 change: 1 addition & 0 deletions redisinsight/ui/src/styles/themes/dark_theme/_theme_color.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ $externalLinkTooltipColor: $externalLinkColor;
$linkToastColor: $externalLinkColor;
$defaultGreenColor: #608b4e;
$insightsTriggerBgColor: #292f47;
$scrollBackgroundColor: rgba(105, 112, 125, 0.5);

$tableRowHoverColor: #070707;
$tableRowSelectedColor: #212536;
Expand Down
1 change: 1 addition & 0 deletions redisinsight/ui/src/styles/themes/dark_theme/darkTheme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
--euiTextSubduedColorHover: #{$euiTextSubduedColorHover};
--euiTitleColor: #{$euiTitleColor};
--euiBreadcrumbActive: #{$euiBreadcrumbActive};
--scrollBackgroundColor: #{$scrollBackgroundColor};

// Contrasty text variants
--euiColorPrimaryText: #{$euiColorPrimaryText};
Expand Down
1 change: 1 addition & 0 deletions redisinsight/ui/src/styles/themes/light_theme/_theme_color.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ $externalLinkTooltipColor: #3163d8;
$linkToastColor: #adbeff;
$defaultGreenColor: #008000;
$insightsTriggerBgColor: #D7E3FA;
$scrollBackgroundColor: rgba(105, 112, 125, 0.5);

$tableRowHoverColor: #fafbfd;
$tableRowSelectedColor: #ebeffa;
Expand Down
1 change: 1 addition & 0 deletions redisinsight/ui/src/styles/themes/light_theme/lightTheme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
--euiTextSubduedColorHover: #{$euiTextSubduedColorHover};
// --euiTitleColor: #{$euiTitleColor};
--euiBreadcrumbActive: #{$euiBreadcrumbActive};
--scrollBackgroundColor: #{$scrollBackgroundColor};

// Contrasty text variants
--euiColorPrimaryText: #{$euiColorPrimaryText};
Expand Down