Skip to content

#RI-2478 - clear history position for wb after end of the list #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022
Merged

#RI-2478 - clear history position for wb after end of the list #352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion redisinsight/ui/src/components/query/Query/Query.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ const Query = (props: Props) => {

const onChange = (value: string = '') => {
setQuery(value)

// clear history position after scrolling all list with empty value
if (value === '' && execHistoryPos >= execHistory.length) {
execHistoryPos = 0
}
}

const handleKeyDown = (e: React.KeyboardEvent) => {
Expand Down Expand Up @@ -127,7 +132,8 @@ const Query = (props: Props) => {
const { editor } = monacoObjects?.current

const position = editor.getPosition()
if (position?.lineNumber !== 1) return
// @ts-ignore
if (position?.lineNumber !== 1 || editor.getContribution('editor.contrib.suggestController')?.model?.state) return

if (execHistory[execHistoryPos]) {
const command = execHistory[execHistoryPos].command || ''
Expand Down