Be/feature/ri 5741 rdi unit tests #3591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ArtemHoruzhenko
changed the base branch from
main
to
feature/RI-5902-rdi-integration
| }, | ||
| { | ||
| provide: RdiClientStorage, | ||
| useFactory: jest.fn(() => ({ |
There was a problem hiding this comment.
let's move this factory to mocks the same way as we do everywhere
| }, | ||
| { | ||
| provide: RdiClientFactory, | ||
| useFactory: jest.fn(() => ({ |
| message: result.message, | ||
| statusCode: HttpStatus.NOT_FOUND, | ||
| error: 'RdiNotFound', | ||
| errorCode: CustomErrorCodes.ConvAiNotFound, |
There was a problem hiding this comment.
ConvAI error on RDI? Could you, please fix it in code.
| transformations: { | ||
| status: RdiDyRunJobStatus.Success, | ||
| // data: {}, | ||
| // error: '' |
| }, | ||
| { | ||
| provide: RdiPipelineAnalytics, | ||
| useValue: { |
There was a problem hiding this comment.
could you please move this to mocks the same way as here useFactory: mockRdiClientProvider,?
|
|
||
| describe('dryRunJob', () => { | ||
| it('should call getOrCreate on rdiClientProvider with the correct metadata', async () => { | ||
| const client = { |
There was a problem hiding this comment.
This will work but is it better to create single mockedClient (which already exists as I remember) and use mockClient.someMethod.mockResolvedValueOnce everywhere without mocking everything inside tests
| }, | ||
| { | ||
| provide: RdiAnalytics, | ||
| useValue: { |
vlad-dargel
dismissed
ArtemHoruzhenko’s stale review
The base branch was changed.
ArtemHoruzhenko
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.