Skip to content

remove auth command logic from recommendation #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

remove auth command logic from recommendation #3605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions redisinsight/api/src/modules/recommendation/providers/recommendation.provider.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,17 +515,6 @@ describe('RecommendationProvider', () => {
.determineSetPasswordRecommendation(client);
expect(setPasswordRecommendation).toEqual(null);
});

it('should return setPassword recommendation when acl command executed with no password error',
async () => {
when(client.sendCommand)
.calledWith(jasmine.arrayContaining(['auth']))
.mockRejectedValue(mockRedisNoPasswordError);

const setPasswordRecommendation = await service
.determineSetPasswordRecommendation(client);
expect(setPasswordRecommendation).toEqual({ name: RECOMMENDATION_NAMES.SET_PASSWORD });
});
});

describe('determineRedisVersionRecommendation', () => {
Expand Down
15 changes: 0 additions & 15 deletions redisinsight/api/src/modules/recommendation/providers/recommendation.provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,10 +367,6 @@ export class RecommendationProvider {
async determineSetPasswordRecommendation(
redisClient: RedisClient,
): Promise<Recommendation> {
if (await this.checkAuth(redisClient)) {
return { name: RECOMMENDATION_NAMES.SET_PASSWORD };
}

try {
const users = await redisClient.sendCommand(
['acl', 'list'],
Expand Down Expand Up @@ -438,17 +434,6 @@ export class RecommendationProvider {
}
}

private async checkAuth(redisClient: RedisClient): Promise<boolean> {
try {
await redisClient.sendCommand(['auth', 'pass']);
} catch (err) {
if (err.message.includes('Client sent AUTH, but no password is set')) {
return true;
}
}
return false;
}

private async determineSearchIndexesForCluster(keys: Key[], client: RedisClient): Promise<RedisString> {
let processedKeysNumber = 0;
let keyName;
Expand Down