Add provider to all frontend telemetry events #5675 #3611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ArtemHoruzhenko
requested changes
Jul 15, 2024
| import { TelemetryEvent } from './events' | ||
| import { checkIsAnalyticsGranted } from './checkAnalytics' | ||
|
|
||
| export const getProvider = (): string => get(store.getState(), 'connections.instances.connectedInstance.provider', '') |
There was a problem hiding this comment.
it is better to have undefined instead of '' (empty string). In this case provider field won't be sent at all
There was a problem hiding this comment.
@ArtemHoruzhenko, fixed to be undefined by default
egor-zalenski
previously approved these changes
Jul 15, 2024
…-is-not-added-always Fix provider is not added to some telemetry events
mariasergeenko
dismissed stale reviews from ArtemHoruzhenko and egor-zalenski
via
1e78db2
mariasergeenko
approved these changes
Jul 22, 2024
mariasergeenko
deleted the
fe/feature/RI-5675-add-provider-to-all-frontend-telemetry-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.