Skip to content

enhance sso errors #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2024
Merged

enhance sso errors #3678

merged 2 commits into from
Aug 9, 2024

Conversation

ArtemHoruzhenko
Copy link
Collaborator

No description provided.

@ArtemHoruzhenko ArtemHoruzhenko self-assigned this Aug 6, 2024
kchepikava
kchepikava previously approved these changes Aug 6, 2024
View reviewed changes
egor-zalenski
egor-zalenski approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@egor-zalenski egor-zalenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Only 1 syntax sugar:
Instead of indexOf(...) > -1 we can use .includes(...)

@mariasergeenko mariasergeenko merged commit dd54ff6 into main Aug 9, 2024
@mariasergeenko mariasergeenko deleted the feature/RI-5933-enhance-sso-errors branch August 9, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kchepikava kchepikava Awaiting requested review from kchepikava

1 more reviewer

@egor-zalenski egor-zalenski egor-zalenski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ArtemHoruzhenko ArtemHoruzhenko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArtemHoruzhenko @egor-zalenski @kchepikava @mariasergeenko