Skip to content

RI-6078 fixed event telemetry on datetime change #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

RI-6078 fixed event telemetry on datetime change #3786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
129100c
RI-6078 fixed event telemetry on datetime change
kchepikava Sep 4, 2024
90ca0d5
RI-6078 added tests for telemetry
kchepikava Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion ...onents/general-settings/datetime-formatter/components/datetime-form/DatetimeForm.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('DatetimeForm', () => {
expect(onFormatChange).toBeCalledWith('Invalid Format')
})

it('should call proper telemetry events', async () => {
it('should call proper telemetry events when custom format is saved', async () => {
const sendEventTelemetryMock = jest.fn()
sendEventTelemetry.mockImplementation(() => sendEventTelemetryMock)

Expand All @@ -66,4 +66,37 @@ describe('DatetimeForm', () => {
}
})
})

it('should call proper telemetry events when radio option is changed to common', async () => {
const sendEventTelemetryMock = jest.fn()
sendEventTelemetry.mockImplementation(() => sendEventTelemetryMock)

render(<DatetimeForm {...instance(mockedProps)} />)

await act(() => fireEvent.click(screen.getByText('Custom')))
await act(() => fireEvent.click(screen.getByText('Pre-selected formats')))

expect(sendEventTelemetry).toBeCalledWith({
event: TelemetryEvent.SETTINGS_DATE_TIME_FORMAT_CHANGED,
eventData: {
currentFormat: dateTimeOptions[0].value
}
})
})

it('should call sendEventTelemetry when common formats is changed', async () => {
const sendEventTelemetryMock = jest.fn()
sendEventTelemetry.mockImplementation(() => sendEventTelemetryMock)

render(<DatetimeForm {...instance(mockedProps)} />)

fireEvent.click(screen.getByTestId('select-datetime-testid'))
await act(() => fireEvent.click(screen.queryByText(dateTimeOptions[1].value) || document))
expect(sendEventTelemetry).toBeCalledWith({
event: TelemetryEvent.SETTINGS_DATE_TIME_FORMAT_CHANGED,
eventData: {
currentFormat: dateTimeOptions[1].value
}
})
})
})
7 changes: 7 additions & 0 deletions .../components/general-settings/datetime-formatter/components/datetime-form/DatetimeForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,12 @@ const DatetimeForm = ({ onFormatChange }: Props) => {
formik.setFieldValue('customFormat', formik.values.format)
} else {
formik.setFieldValue('format', formik.values.commonFormat)
sendEventTelemetry({
event: TelemetryEvent.SETTINGS_DATE_TIME_FORMAT_CHANGED,
eventData: {
currentFormat: formik.values.commonFormat,
}
})
formik.handleSubmit()
}
}
Expand Down Expand Up @@ -154,6 +160,7 @@ const DatetimeForm = ({ onFormatChange }: Props) => {
onChange={(option) => onCommonFormatChange(option)}
disabled={formik.values.selectedRadioOption !== DatetimeRadioOption.Common}
data-test-subj="select-datetime"
data-testid="select-datetime-testid"
/>
</div>
),
Expand Down