e2e - cypher tests #383
Merged
e2e - cypher tests #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofersteinberg
suggested changes
Mar 16, 2022
| .meta({ rte: rte.standalone }) | ||
| .after(async() => { | ||
| //Delete database | ||
| await deleteDatabase(ossStandaloneConfig.databaseName); |
There was a problem hiding this comment.
Do you aware it's overlapping the afterEach? Also, it's the same, why need it twice?
There was a problem hiding this comment.
thanks, you are right
removed
| //Delete database | ||
| await deleteDatabase(ossStandaloneConfig.databaseName); | ||
| }) | ||
| ('Verify that wheh popover Editor is displayed user can see it is populated with the script that was detected between the quotes or it is blank if quotes were empty', async t => { |
There was a problem hiding this comment.
You have a typo (wheh)
Also, IMO the names of the tests in this fixture are too long
There was a problem hiding this comment.
reduced the names where possible
| //Close popover editor and re-open with added script | ||
| await t.pressKey('esc'); | ||
| await t.typeText(workbenchPage.queryInput, `${command} "${script}`, { replace: true }); | ||
| await t.debug(); |
ofersteinberg
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.