RI-6067 implemented reset/start/stop rdi functionality #3843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
redisinsight/api/test/api/rdi/pipeline/POST-rdi-id-pipeline-reset.test.ts
Fixed
Show fixed
Hide fixed
redisinsight/api/test/api/rdi/pipeline/POST-rdi-id-pipeline-start.test.ts
Fixed
Show fixed
Hide fixed
redisinsight/api/test/api/rdi/pipeline/POST-rdi-id-pipeline-stop.test.ts
Fixed
Show fixed
Hide fixed
rsergeenko
reviewed
Sep 19, 2024
| export interface PipelineButtonProps { | ||
| onClick: () => void; | ||
| disabled: boolean; | ||
| loading: boolean; |
There was a problem hiding this comment.
please, remove semicolons
| // font-weight: 400 !important; | ||
| // font-size: 14px !important; | ||
| // line-height: 16.8px !important; | ||
| // } |
There was a problem hiding this comment.
please, remove commented code
| // font-weight: 400 !important; | ||
| // font-size: 14px !important; | ||
| // line-height: 16.8px !important; | ||
| // } |
There was a problem hiding this comment.
please, remove commented code
| // font-weight: 400 !important; | ||
| // font-size: 14px !important; | ||
| // line-height: 16.8px !important; | ||
| // } |
| @@ -0,0 +1,26 @@ | |||
| .stopPipelineBtn { | |||
There was a problem hiding this comment.
if we use the same styles for several buttons, we can move it to one file
| {pageLoading && ( | ||
| <div className={styles.cover}> | ||
| <EuiLoadingSpinner size="xl" /> | ||
| </div> |
|
|
||
| export function stopPipelineAction( | ||
| rdiInstanceId: string, | ||
| callback: (result: IActionPipelineResultProps) => void, |
There was a problem hiding this comment.
it's better to split to onSuccess and onFinish
|
|
||
| export function startPipelineAction( | ||
| rdiInstanceId: string, | ||
| callback: (result: IActionPipelineResultProps) => void, |
|
|
||
| export function resetPipelineAction( | ||
| rdiInstanceId: string, | ||
| callback: (result: IActionPipelineResultProps) => void, |
| resetPipelineFailure: (state, { payload }: PayloadAction<string>) => { | ||
| state.reset.loading = false | ||
| state.reset.error = payload | ||
| }, |
There was a problem hiding this comment.
a lot similar actions, could you think how to have one? Maybe add some variables (isStarted)? Do we use all these errors at the same time?
|
approve BE |
egor-zalenski
previously approved these changes
Sep 20, 2024
…rdi-pipelines add reset/stop pipeline tests
mariasergeenko
dismissed stale reviews from egor-zalenski and rsergeenko
via
487057b
mariasergeenko
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.