add formatters #3885
Merged
add formatters #3885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-dargel
reviewed
Oct 4, 2024
vlad-dargel
reviewed
Oct 4, 2024
| const buf = fflate.strToU8(rawValue); | ||
| const value = Buffer.from(fflate.zlibSync(buf)); | ||
|
|
||
| await this.createHash(prefix, value, true); |
There was a problem hiding this comment.
do we need createString here too?
There was a problem hiding this comment.
and in all methods below
vlad-dargel
reviewed
Oct 7, 2024
| await this.createBrotliPickleKeys(); | ||
| } | ||
|
|
||
| private async createBrotliUnicodeKeys() { |
There was a problem hiding this comment.
what about comments with description for all your methods?
There was a problem hiding this comment.
I believe that for private methods, especially those with self-explanatory names, comments may not always add significant value. it just clutters up the code
vlad-dargel
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.