E2e/feature/ri 6268 enhance form to add database connections #4098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/RI-6268_enhance-form-to-add-database-connections
| //*The following categories are ordered alphabetically (Alerts, Buttons, Checkboxes, etc.). | ||
| //------------------------------------------------------------------------------------------- | ||
| // BUTTONS | ||
| addDatabaseButton = Selector('[data-testid^=add-redis-database]'); |
There was a problem hiding this comment.
could we move it to dialog instead of components?
| addDatabaseManually = Selector('[data-testid=add-manual]'); | ||
| addAutoDiscoverDatabase = Selector('[data-testid=add-auto]'); | ||
| addDatabaseManually = Selector('[data-testid=add-database_tab_manual]'); | ||
| addAutoDiscoverDatabase = Selector('[data-testid=add-database_tab_software]'); |
There was a problem hiding this comment.
don't you want to split the locators to different tabs like in Insight panel?
There was a problem hiding this comment.
not yet, we'll totally redo this popover, including tabs and content inside, so no need to do this right now
vlad-dargel
had a problem deploying
to
e2e-approve
GitHub Actions
Error
mariasergeenko
approved these changes
Nov 18, 2024
vlad-dargel
merged commit b77534d
into
feature/RI-6265_update-list-of-databases
6 of 7 checks passed
vlad-dargel
deleted the
e2e/feature/RI-6268_enhance-form-to-add-database-connections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.