Skip to content

CR-274: Add correlation ID to session metadata #4148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

CR-274: Add correlation ID to session metadata #4148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions redisinsight/api/src/common/decorators/session/session-metadata.decorator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { v4 as uuidv4 } from 'uuid';
import { BadRequestException, createParamDecorator, ExecutionContext } from '@nestjs/common';
import { plainToClass } from 'class-transformer';
import { Validator } from 'class-validator';
Expand All @@ -9,10 +10,12 @@ const validator = new Validator();
export const sessionMetadataFromRequest = (request: Request): SessionMetadata => {
const userId = request.res?.locals?.session?.data?.userId.toString();
const sessionId = request.res?.locals?.session?.data?.sessionId.toString();
const correlationId = request.res?.locals?.session?.correlationId || uuidv4();

const requestSession = {
userId,
sessionId,
correlationId,
};

// todo: do not forget to deal with session vs sessionMetadata property
Expand Down
4 changes: 4 additions & 0 deletions redisinsight/api/src/common/models/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export class SessionMetadata implements ISessionMetadata {
@IsString()
uniqueId?: string;

@IsOptional()
@IsString()
correlationId?: string;

/**
* Validates session metadata required properties to be defined
* Must be used in all the places that works with clients
Expand Down