Skip to content

try update statics only after default data populated #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2022
Merged

try update statics only after default data populated #418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
857b1f4
try update statics only after default data populated
Mar 21, 2022
9991de1
try update statics only after default data populated
Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions redisinsight/api/src/modules/statics-management/providers/auto-updated-statics.provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,7 @@ export class AutoUpdatedStaticsProvider implements OnModuleInit {
*/
onModuleInit() {
// async operation to not wait for it and not block user in case when no internet connection
Promise.all([
this.initDefaults(),
this.autoUpdate(),
]);
this.initDefaults().finally(this.autoUpdate.bind(this));
}

/**
Expand Down Expand Up @@ -59,7 +56,7 @@ export class AutoUpdatedStaticsProvider implements OnModuleInit {
try {
await this.updateStaticFiles();
} catch (e) {
this.logger.error('Unable to update auto static files', e);
this.logger.warn('Unable to update auto static files', e);
}
}
}
Expand All @@ -85,7 +82,7 @@ export class AutoUpdatedStaticsProvider implements OnModuleInit {
try {
return await getFile(new URL(join(this.options.updateUrl, this.options.zip)).toString());
} catch (e) {
this.logger.error('Unable to get remote archive', e);
this.logger.warn('Unable to get remote archive', e);
return null;
}
}
Expand All @@ -109,7 +106,7 @@ export class AutoUpdatedStaticsProvider implements OnModuleInit {
try {
return await getFile(new URL(join(this.options.updateUrl, this.options.buildInfo)).toString());
} catch (e) {
this.logger.error('Unable to get remote build info', e);
this.logger.warn('Unable to get remote build info', e);
return {};
}
}
Expand All @@ -124,7 +121,7 @@ export class AutoUpdatedStaticsProvider implements OnModuleInit {
'utf8',
));
} catch (e) {
this.logger.error('Unable to get local checksum', e);
this.logger.warn('Unable to get local checksum', e);
return {};
}
}
Expand Down