Skip to content

#RI-6417 - fix values for the form #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

#RI-6417 - fix values for the form #4195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions redisinsight/ui/src/pages/home/HomePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
import { sendEventTelemetry, sendPageViewTelemetry, TelemetryEvent, TelemetryPageView } from 'uiSrc/telemetry'
import { appRedirectionSelector, setUrlHandlingInitialState } from 'uiSrc/slices/app/url-handling'
import { UrlHandlingActions } from 'uiSrc/slices/interfaces/urlHandling'
import { AddDbType, CREATE_CLOUD_DB_ID } from 'uiSrc/pages/home/constants'
import { CREATE_CLOUD_DB_ID } from 'uiSrc/pages/home/constants'
import { appFeatureFlagsFeaturesSelector } from 'uiSrc/slices/app/features'

import DatabasesList from './components/database-list-component'
Expand Down Expand Up @@ -174,7 +174,7 @@ const HomePage = () => {
})
}

const handleAddInstance = (addDbType = AddDbType.manual) => {
const handleAddInstance = () => {
setOpenDialog(OpenDialogName.AddDatabase)
dispatch(setEditedInstance(null))
}
Expand Down Expand Up @@ -212,7 +212,6 @@ const HomePage = () => {
<DatabasePanelDialog
editMode={openDialog === OpenDialogName.EditDatabase}
urlHandlingAction={action}
initialValues={dbConnection ?? null}
editedInstance={
openDialog === OpenDialogName.EditDatabase
? editedInstance
Expand Down
5 changes: 2 additions & 3 deletions redisinsight/ui/src/pages/home/components/database-panel-dialog/DatabasePanelDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import styles from './styles.module.scss'
export interface Props {
editMode: boolean
urlHandlingAction?: Nullable<UrlHandlingActions>
initialValues?: Nullable<Record<string, any>>
editedInstance: Nullable<Instance>
onClose: () => void
onDbEdited?: () => void
Expand All @@ -40,10 +39,9 @@ const DatabasePanelDialog = (props: Props) => {
const {
editMode,
onClose,
initialValues: initialValuesProp,
} = props

const [initialValues, setInitialValues] = useState(initialValuesProp)
const [initialValues, setInitialValues] = useState(null)
const [connectionType, setConnectionType] = useState<Nullable<AddDbType>>(null)
const [modalHeader, setModalHeader] = useState<Nullable<React.ReactNode>>(null)

Expand Down Expand Up @@ -72,6 +70,7 @@ const DatabasePanelDialog = (props: Props) => {
useEffect(() => {
if (action === UrlHandlingActions.Connect) {
setConnectionType(AddDbType.manual)
setInitialValues(dbConnection)
}
}, [action, dbConnection])

Expand Down
Loading