show original placeholder without applying visualization for big resp… #4197
Conversation
…onses message placeholder
ArtemHoruzhenko
requested review from
egor-zalenski,
kchepikava,
rsergeenko and
KIvanow
| )} | ||
| </> | ||
| )} | ||
| {isSizeLimitExceededResponse(result) |
There was a problem hiding this comment.
Yeah. Otherwise we must split/refactor entire component which is time-consuming for such small task.
There was a problem hiding this comment.
If any of notices such deep nesting and ternaries being used in the rendering, or anything else that might be a suboptimal practice, but it is done to get it done for now. Please, tag me, so we can discuss it and make a task for it to improve it whenever we have time. Otherwise we'll forget about it and things like these or similar will keep falling through the cracks.
It will also be more productive than emotes ;)
Tagging @pd-redis and @seth-riedel so they can see it as well
There was a problem hiding this comment.
why not use
(isGroupResults(resultsMode) || isSizeLimitExceededResponse(result)) ? ...There was a problem hiding this comment.
Love the initiative, @KIvanow! While I’m slightly skeptical about the 'whenever we have time' part, it’s definitely a step forward. And hey, emojis might be simple, but they’ve got some serious discussion-starting power! 😸✨
|
Please start the commits with the ticket id so we can more easily associate the changes with what caused them whenever we need to change anything later on |
mariasergeenko
temporarily deployed
to
development
GitHub Actions
Inactive
…onses message placeholder