CR-220: wrap PSUBSCRIBE_COMMAND output with FeatureFlagComponent #4203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd-redis
requested review from
KIvanow,
pawelangelow,
seth-riedel,
ArtemHoruzhenko,
egor-zalenski and
rsergeenko
KIvanow
approved these changes
Dec 12, 2024
pawelangelow
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
LGTM!
Looks like SUBSCRIBE_COMMAND_CLI and PSUBSCRIBE_COMMAND_CLI tests are very very similar and I guess we can reduce the code there:
const prepareStore = ({ flag }) => set(
cloneDeep(initialStateDefault),
`app.features.featureFlags.features.${FeatureFlags.envDependent}`,
{ flag }
)
or with describe.each()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.