Skip to content

E2e/bugfix/fixes for e2e release #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 17, 2024
Merged

E2e/bugfix/fixes for e2e release #4218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3da4f36
e2e/bugfix/fixes-for-e2e-release
vlad-dargel Dec 17, 2024
4b5395b
skip cloud db test
vlad-dargel Dec 17, 2024
e8aa5f3
fix for Connecting to the databases verifications
vlad-dargel Dec 17, 2024
4f37955
skip oss cluster ssh test
vlad-dargel Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/e2e/pageObjects/dialogs/add-redis-database-dialog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export class AddRedisDatabaseDialog {
cloneDatabaseButton = Selector('[data-testid=clone-db-btn]');
cancelButton = Selector('[data-testid=btn-cancel]');
testConnectionBtn = Selector('[data-testid=btn-test-connection]');
backButton = Selector('[data-testid=back-btn]');

// TEXT INPUTS (also referred to as 'Text fields')
disabledDatabaseInfo = Selector('[class=euiListGroupItem__label]');
Expand All @@ -35,7 +36,7 @@ export class AddRedisDatabaseDialog {
databaseAliasInput = Selector('[data-testid=name]');
passwordInput = Selector('[data-testid=password]');
usernameInput = Selector('[data-testid=username]');
connectionUrlInput = Selector('[data-testid=connectionURL]');
connectionUrlInput = Selector('[data-testid=connection-url]');
accessKeyInput = Selector('[data-testid=access-key]');
secretKeyInput = Selector('[data-testid=secret-key]');
databaseIndexInput = Selector('[data-testid=db]');
Expand Down
3 changes: 2 additions & 1 deletion tests/e2e/tests/electron/critical-path/database/add-ssh-db.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ test('Adding database with SSH', async t => {
await myRedisDatabasePage.clickOnDBByName(sshDbPasscode.databaseName);
await Common.checkURLContainsText('browser');
});
test('Verify that OSS Cluster database with SSH can be added and work correctly', async t => {
// Unskip after fixing RI-6386
test.skip('Verify that OSS Cluster database with SSH can be added and work correctly', async t => {
const sshWithPass = {
...sshParams,
sshPassword: 'pass'
Expand Down
6 changes: 3 additions & 3 deletions tests/e2e/tests/web/critical-path/database/connecting-to-the-db.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ test
.expect(myRedisDatabasePage.AddRedisDatabaseDialog.databaseAliasInput.value).eql(`${defaultHost}:${defaultPort}`, 'Default db alias not prepopulated');
// Verify that the Host, Port, Database Alias values pre-populated by default for Sentinel
await t
.click(myRedisDatabasePage.AddRedisDatabaseDialog.addAutoDiscoverDatabase)
.click(myRedisDatabasePage.AddRedisDatabaseDialog.backButton)
.click(myRedisDatabasePage.AddRedisDatabaseDialog.redisSentinelButton);
await t
.expect(myRedisDatabasePage.AddRedisDatabaseDialog.hostInput.value).eql(defaultHost, 'Default sentinel host not prepopulated')
Expand Down Expand Up @@ -195,13 +195,13 @@ test
await myRedisDatabasePage.clickOnDBByName(sshDbPass.databaseName);
await Common.checkURLContainsText('browser');
});
test
// Unskip in RI-6478
test.skip
.meta({ rte: rte.none })
.before(async() => {
await databaseAPIRequests.deleteAllDatabasesApi();
await databaseHelper.acceptLicenseTerms();
})('Verify that create free cloud db is displayed always', async t => {

const externalPageLinkList = 'https://redis.io/try-free?utm_source=redisinsight&utm_medium=app&utm_campaign=list_of_databases';
const externalPageLinkNavigation = 'https://redis.io/try-free?utm_source=redisinsight&utm_medium=app&utm_campaign=navigation_menu';

Expand Down
Loading