Skip to content

Conversation

pawelangelow
Copy link
Collaborator

@pawelangelow pawelangelow commented Jan 6, 2025

Description

This task has 3 sub-tasks:

  • First is to hide the RDI version on the Status page as it's incorrect.

  • The second one is to display the proper version of RDI on the connections screen.

  • And the third to update few texts related to the task.

  • Add tests

Preview

Screenshot 2025-01-06 at 17 00 45

@pawelangelow pawelangelow self-assigned this Jan 6, 2025
@pawelangelow pawelangelow marked this pull request as draft January 6, 2025 15:03
@pawelangelow pawelangelow marked this pull request as ready for review January 7, 2025 12:22
pd-redis
pd-redis previously approved these changes Jan 8, 2025
@pawelangelow pawelangelow changed the base branch from main to feature/dynamic-dependencies January 15, 2025 20:06
@pawelangelow pawelangelow requested review from pd-redis, KIvanow, rsergeenko and kchepikava and removed request for pd-redis January 16, 2025 11:28
rsergeenko
rsergeenko previously approved these changes Jan 16, 2025
Copy link
Contributor

@rsergeenko rsergeenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fe looks good

pd-redis
pd-redis previously approved these changes Jan 16, 2025
Copy link
Collaborator

@pd-redis pd-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KIvanow
Copy link
Contributor

KIvanow commented Jan 16, 2025

Why is this pointing to feature/dynamic-dependencies and not to main?

@pd-redis
Copy link
Collaborator

Why is this pointing to feature/dynamic-dependencies and not to main?

Have we changed the target for PRs to main? So far it has been feature/dynamic-dependencies for all PRs

@pawelangelow pawelangelow changed the base branch from feature/dynamic-dependencies to main January 16, 2025 15:22
@pawelangelow pawelangelow dismissed stale reviews from pd-redis, ViktarStarastsenka, and rsergeenko January 16, 2025 15:22

The base branch was changed.

@mariasergeenko mariasergeenko merged commit a73eb88 into main Jan 17, 2025
12 checks passed
@mariasergeenko mariasergeenko deleted the feature/RI-6457/get-proper-rdi-version branch January 17, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants