Skip to content

Conversation

pawelangelow
Copy link
Collaborator

@pawelangelow pawelangelow commented Jan 11, 2025

This PR includes cosmetic changes across multiple files, such as fixing semicolons, spaces, and other formatting issues. There are no functional or logic changes - only adjustments to resolve linting problems.

⚠️ It's easier to see some of the file changes locally, as GitHub interface... well, 2773 files 😸

@seth-riedel
Copy link
Contributor

I don't think we can do this right now. It will create a maintenance nightmare between our long-lived branch and main :(

@pd-redis
Copy link
Collaborator

I tend to agree with @seth-riedel , I would prefer to have consistent formatting across the files, but not sure if merging the conflicts is worth it.
It could probably be better to enforce git hook on commit or merge to apply formatting to changed files

@pawelangelow
Copy link
Collaborator Author

I tend to agree with @seth-riedel , I would prefer to have consistent formatting across the files, but not sure if merging the conflicts is worth it. It could probably be better to enforce git hook on commit or merge to apply formatting to changed files

Yup, my idea is to have:

  • pre-commit hook
  • github action to run lint and prettier

If we go with just the pre-commit hook or something in this manner, won't save us the trouble - next time they are run, this would be the changeset of files again. That's why I decided to leave them as separate PR, as no logical change is done - just the comsetics changes.

About the conflicts, as my comment in #4273 - I believe this would be do-it-once task. Potentially, if someone changed these files the conflict resolving is relatively easy - just run the scripts with the applied changes.

@pawelangelow
Copy link
Collaborator Author

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants