#RI-6554 - update icons and connectivity buttons #4292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchepikava
previously approved these changes
Jan 17, 2025
| color: var(--buttonSecondaryTextColor) !important; | ||
| box-shadow: none !important; | ||
|
|
||
| &.primary { |
There was a problem hiding this comment.
Looks like we still have a component that uses .primary. Either we should remove this style from the component, or keep it here
|
|
||
| .star { | ||
| margin-right: 4px; | ||
| :global(.euiButton__text) { |
There was a problem hiding this comment.
Question: why do we need :global?
There was a problem hiding this comment.
since there is a global class, not scoped
Comment on lines
8
to
10
| export interface Values { | ||
| connectionURL?: string | ||
| } |
| <EuiFlexItem grow={1} key={id}> | ||
| <EuiFlexGrid> | ||
| {CONNECTIVITY_OPTIONS.map(({ id, type, title, icon }) => ( | ||
| <EuiFlexItem grow={false} key={id}> |
There was a problem hiding this comment.
Haven't tested, but isn't grow={false} = grow={0}?
There was a problem hiding this comment.
no, there are type FlexItemGrowSize = 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | true | false | null;
mariasergeenko
temporarily deployed
to
development
GitHub Actions
Inactive
mariasergeenko
temporarily deployed
to
development
GitHub Actions
Inactive
mariasergeenko
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.