Skip to content

#RI-6624 - fix slow request for json #4315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

#RI-6624 - fix slow request for json #4315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions redisinsight/api/src/modules/browser/rejson-rl/rejson-rl.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export class RejsonRlService {
path: string,
type: string,
): Promise<SafeRejsonRlDataDto[]> {
const result = [];
const promises = [];
let objectKeys: string[];
let arrayLength: number;

Expand All @@ -174,8 +174,8 @@ export class RejsonRlService {
? `['${objectKey}']`
: `["${objectKey}"]`;
const fullObjectKeyPath = `${rootPath}${childPath}`;
result.push(
await this.getDetails(
promises.push(
this.getDetails(
client,
keyName,
fullObjectKeyPath,
Expand All @@ -184,26 +184,22 @@ export class RejsonRlService {
);
}

break;
return Promise.all(promises);
case 'array':
arrayLength = await client.sendCommand([
BrowserToolRejsonRlCommands.JsonArrLen,
keyName,
path,
], { replyEncoding: 'utf8' }) as number;

for (let i = 0; i < arrayLength; i += 1) {
const fullObjectKeyPath = `${path === '.' ? '' : path}[${i}]`;
result.push(
await this.getDetails(client, keyName, fullObjectKeyPath, i),
);
promises.push(this.getDetails(client, keyName, fullObjectKeyPath, i));
}
break;

return Promise.all(promises);
default:
return this.forceGetJson(client, keyName, path);
}

return result;
}

/**
Expand Down
Loading