Skip to content

RI-6667 better handle errors for recommendations to avoid crashes #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

RI-6667 better handle errors for recommendations to avoid crashes #4330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions redisinsight/api/src/modules/database-recommendation/database-recommendation.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export class DatabaseRecommendationService {
clientMetadata: ClientMetadata,
recommendationNames: string[],
data: any,
): Promise<Map<string, DatabaseRecommendation[]>> {
): Promise<Record<string, DatabaseRecommendation>> {
try {
const newClientMetadata = {
...clientMetadata,
Expand All @@ -108,10 +108,10 @@ export class DatabaseRecommendationService {
return results.reduce((acc, result, idx) => ({
...acc,
[recommendationNames[idx]]: result,
}), {} as Map<string, DatabaseRecommendation[]>);
}), {});
} catch (e) {
this.logger.warn('Unable to check recommendation', e, clientMetadata);
return null;
return {};
}
}

Expand All @@ -126,8 +126,12 @@ export class DatabaseRecommendationService {
recommendationName: string,
data: any,
): Promise<DatabaseRecommendation> {
const result = await this.checkMulti(clientMetadata, [recommendationName], data);
return result[recommendationName];
try {
const result = await this.checkMulti(clientMetadata, [recommendationName], data);
return result[recommendationName];
} catch (e) {
return null;
}
}

/**
Expand Down