RI-6384: add tags for databases (UI - part 1) #4426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrumTy
changed the title
KrumTy
requested review from
KIvanow,
pawelangelow,
seth-riedel,
ArtemHoruzhenko,
pd-redis,
dantovska and
Copilot
KrumTy
changed the title
dantovska
approved these changes
Mar 18, 2025
|
|
||
| .tagBadge { | ||
| color: #8BA2FF !important; | ||
| background-color: #292F47 !important; |
There was a problem hiding this comment.
Is there maybe some predefined color used? Just checking - not sure if it is okay to just hardcode the color.
There was a problem hiding this comment.
addressed in the next PR
KrumTy
added a commit
that referenced
this pull request
Apr 7, 2025
* RI-6893: init tag module (basic CRUD) * RI-6893: tag - key and value validation * RI-6893: tag - add unique constraints for key-value pair * RI-6384: link databases to tags * RI-6893: update database tag linking * RI-6384: add ready only tags * RI-6893: expose bulk update method for tags * update logging * RI-6893: update db tag methods * RI-6893: optimize bulk tags updates * RI-6893: add unit tests for database tags * update database integration tests schema * RI-6384: resolve failing tests * RI-6384: fix failing tests * RI-6384: add tests for databases with tags * RI-6893: remove read-only tags * RI-6893: remove readonly tags tests * RI-6893: update tags migration script * RI-6384: resolve comments * RI-6384: add tags for databases (UI - part 1) (#4426) * RI-6895: list db tags + RI-6896: sort by db tags * RI-6895: search db by tag * RI-6897: init filter by tags * RI-6897: refactor selected tags to use Set * RI-6897: filter databases by selected tags * RI-6897: hide tags filter if there are no tags * RI-6384: fix failing test * RI-6384: revert SearchDatabasesList changes * RI-6384: add test for selected tags * RI-6897: add tests for TagsCell * RI-6897: fix filter by tag issue * RI-6384: add tags for databases (UI - part 2) (#4453) * RI-6895: list db tags + RI-6896: sort by db tags * RI-6895: search db by tag * RI-6897: init filter by tags * RI-6897: refactor selected tags to use Set * RI-6897: filter databases by selected tags * RI-6897: hide tags filter if there are no tags * RI-6384: fix failing test * RI-6384: revert SearchDatabasesList changes * RI-6384: add test for selected tags * RI-6897: add tests for TagsCell * RI-6897: fix filter by tag issue * RI-6898: init tags edit form * RI-6898: finalize design for tags CRUD page * RI-6898: disable tags save if there are no changes * RI-6898: fix tags input focus issue * RI-6898: save db tags * RI-6898: add toast message when editing tags * RI-6898: refetch tags on tags update * RI-6898: add tag validation * RI-6898: unique tag keys * RI-6898: edit tags * RI-6898: refactor tags edit modal * RI-6898: add clouddb tags warning * RI-6898: fix resize bg color * RI-6898: fix theme color * fix tags list theme color * RI-6898: add new tag field design updates * RI-6898: refactor tag suggestions * RI-6898: refactor tag input field * add tests for manage tags modal * cleanup leftover * refactor tag inputs * address comments feedback * fix tags sort * RI-6091, RI-6092: tags import/export * refetch tags on import/delete * fix db controls position * fix db integration tests * fix tags export integration test * RI-6903: import tags from cloud via autodiscovery * fix integration tests * fix failing unit tests * fix some integration tests * fix some integration tests * fix more integration tests * fix integration test * fix final integration test * fix unit test * fix unit tests * use Promise.all for db/tags cloud fetch * use PartialType UpdateTagDto * add tags unit test mocks * move TagModule import to core modules * cloud db tests: change toMatchObject -> toEqual * refactor cleanupUnusedTags - delete in single query * increase controls gap * add instancesWithTagCount telemetry data to the DATABASE_LIST_PAGE event (#4468) * add integration tests for database tags patch/delete * RI-6091, RI-6092, RI-6903: database tags import/export/autodiscovery (#4459) * RI-6091, RI-6092: tags import/export * refetch tags on import/delete * fix db controls position * fix db integration tests * fix tags export integration test * RI-6903: import tags from cloud via autodiscovery * fix integration tests * fix failing unit tests * fix some integration tests * fix some integration tests * fix more integration tests * fix integration test * fix final integration test * fix unit test * fix unit tests * use Promise.all for db/tags cloud fetch * use PartialType UpdateTagDto * add tags unit test mocks * move TagModule import to core modules * cloud db tests: change toMatchObject -> toEqual * refactor cleanupUnusedTags - delete in single query * increase controls gap * add integration tests for database tags patch/delete * RI-6893: encrypt database tags (#4476) * RI-6893: encrypt database tags * refactor LocalTagRepository * update tags integration tests * RI-6384 refactor tags encryption * RI-6384 fix tag entities encryption flows * RI-6384 cleanup getOrCreateByKeyValuePairs * fix unit tests --------- Co-authored-by: ArtemHoruzhenko <artsiom.kharuzhenka@gmail.com> * resolve merge conflict * fix: no duplicated tags by key for a single database should be allowed * add integration test for duplicated tag keys patch --------- Co-authored-by: dantovska <dijana.antovska@redis.com> Co-authored-by: ArtemHoruzhenko <artsiom.kharuzhenka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The functionality mimics the tags in redis cloud.