Skip to content

Conversation

yashschandra
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2025

CLA assistant check
All committers have signed the CLA.

@yashschandra
Copy link
Contributor Author

resolves #4432

Copy link
Collaborator

@pawelangelow pawelangelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks for your work!
It's always great to see people engage in the process with fresh ideas and perspectives - I really appreciate it. 🙏 🍺

Second, apologies for the delay.

Third, now that the requirements are clear, the changes make sense and look good overall. 🚀
I just have a few comments related to code style. Here's what I suggest:

  • Rebase onto the latest main
  • Go through the comments
  • Add some unit tests

I'm happy to help with any (or all) of these steps - just let me know!

@yashschandra
Copy link
Contributor Author

First of all, thanks for your work! It's always great to see people engage in the process with fresh ideas and perspectives - I really appreciate it. 🙏 🍺

Second, apologies for the delay.

Third, now that the requirements are clear, the changes make sense and look good overall. 🚀 I just have a few comments related to code style. Here's what I suggest:

  • Rebase onto the latest main
  • Go through the comments
  • Add some unit tests

I'm happy to help with any (or all) of these steps - just let me know!

Restructured code as suggested

@yashschandra yashschandra requested a review from pawelangelow May 12, 2025 22:03
@pawelangelow
Copy link
Collaborator

@yashschandra I opened a PR with a few additional tweaks and polish to complement your changes. yashschandra#1

@yashschandra
Copy link
Contributor Author

@yashschandra I opened a PR with a few additional tweaks and polish to complement your changes. yashschandra#1

@pawelangelow Merged your changes. Also removed unnecessary update settings call. Please check now.

Copy link
Collaborator

@pawelangelow pawelangelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time and cooperation on this PR! 🙏

@pawelangelow pawelangelow merged commit 42c816e into redis:main May 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants