Feature/ri 6205 enhance logs #4521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested review from
KIvanow,
KrumTy,
dantovska,
pawelangelow and
pd-redis
as code owners
ArtemHoruzhenko
force-pushed
the
feature/RI-6205-enhance-logs
branch
from
adedf58 to
9555209
Compare
KIvanow
previously approved these changes
Apr 25, 2025
pd-redis
reviewed
Apr 25, 2025
Comment on lines
7
to
11
| const error1 = new Error('Original error'); | ||
| error1['some'] = 'field'; | ||
| const error2 = new NotFoundException('Not found', { cause: error1 }); | ||
| const error3 = new BadRequestException('Bad req', { cause: error2 }); | ||
| const error4 = new CloudOauthMisconfigurationException('Misconfigured', { cause: error3 }); |
There was a problem hiding this comment.
These names are not very descriptive
Suggested change
| const error1 = new Error('Original error'); | |
| error1['some'] = 'field'; | |
| const error2 = new NotFoundException('Not found', { cause: error1 }); | |
| const error3 = new BadRequestException('Bad req', { cause: error2 }); | |
| const error4 = new CloudOauthMisconfigurationException('Misconfigured', { cause: error3 }); | |
| const genericError = new Error('Original error'); | |
| genericError['some'] = 'field'; | |
| const notFoundError = new NotFoundException('Not found', { cause: error1 }); | |
| const badRequestError = new BadRequestException('Bad req', { cause: error2 }); | |
| const cloudError = new CloudOauthMisconfigurationException('Misconfigured', { cause: error3 }); |
There was a problem hiding this comment.
Ok. I've changed them to more meaningful names
|
|
||
| const mockLogData: any = { | ||
| sessionMetadata: mockSessionMetadata, | ||
| error: error4, |
There was a problem hiding this comment.
Suggested change
| error: error4, | |
| error: cloudError, |
| sessionMetadata: mockSessionMetadata, | ||
| error: error4, | ||
| data: [ | ||
| error3, |
There was a problem hiding this comment.
Suggested change
| error3, | |
| badRequestError, |
pd-redis
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.