RI-6953: Send telemetry events for ReJSON used editor #4537
Conversation
pawelangelow
requested review from
KrumTy,
dantovska,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
| import { AppDispatch, RootState } from '../store' | ||
|
|
||
| export const JSON_LENGTH_TO_FORCE_RETRIEVE = 200 | ||
| const TELEMETRY_KEY_LEVEL_WHOLE_KEY = 'entireKey' |
There was a problem hiding this comment.
key is named ..._WHOLE_KEY the value entireKey. Why not ..._ENTIRE_KEY
| // Suppress Redux warnings about missing reducers | ||
| beforeAll(() => { | ||
| console.error = (...args: any[]) => { | ||
| const message = args[0] | ||
| if ( | ||
| typeof message === 'string' && | ||
| message.includes('No reducer provided for key') | ||
| ) { | ||
| return | ||
| } | ||
|
|
||
| originalConsoleError(...args) | ||
| } | ||
| }) |
There was a problem hiding this comment.
Why for this test specifically?
There was a problem hiding this comment.
This is a brand new test suite, and I'm adding it here. I'm suppressing the expected Redux warnings to keep the logs clean and free of noise.
| } | ||
| }) | ||
|
|
||
| const rejson = await import('uiSrc/slices/browser/rejson') |
There was a problem hiding this comment.
The mocking process for this file is a bit tricky. It seems something gets imported before Jest has a chance to apply the usual jest.mock() logic, so the standard mocking approach doesn’t work here. That’s why this file uses jest.resetModules() - to force a clean module state.
| } | ||
|
|
||
| const getJsonPathLevel = (path: string): string => { | ||
| const getJsonPathLevel = (path: string): number => { |
There was a problem hiding this comment.
I think some tests verifying this funciton works as expected won't hurt
pawelangelow
dismissed stale reviews from KIvanow, KrumTy, and dantovska
via
5b2587f
rejsonslice is hard to test due to its architecture. As a temporary solution, I added a new test suite, where modules can be dynamically reloaded in order to use thejestmocks. Ideally, the business logic from this slice should be extracted and properly tested.Apart from the event properties, this CL fixes a bug with reporting the JSON path level of nesting.