RI-7139: Fix json editor styles #4566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelangelow
requested review from
KrumTy,
dantovska,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
KIvanow
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR fe7b8af, I've broken the styles a bit.
Generally, there are a few magics in the JSON editor HTML + CSS structure, like
calc(100%—X),:global(), orposition: absoluteon elements, that can be aligned without changing their position property. Cleaning this up properly would require a larger refactor. So for now, this PR introduces separate classes for the two editors to apply different styles as a workaround.Note: header height changed from 115 to 108