RI-7046: replace EuiCheckbox #4576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd-redis
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko and
KIvanow
as code owners
|
Before: After: |
dantovska
reviewed
May 28, 2025
redisinsight/ui/src/components/base/forms/checkbox/Checkbox.tsx
Outdated
Show resolved
Hide resolved
pd-redis
force-pushed
the
feature/fe/RI-7046-replace-eui-checkbox
branch
from
cfef56e to
612ce31
Compare
…vide a built-in prop to control label size
pd-redis
force-pushed
the
feature/fe/RI-7046-replace-eui-checkbox
branch
from
612ce31 to
14798bd
Compare
KrumTy
reviewed
May 30, 2025
Comment on lines
+2
to
+6
| import RedisAIDark from 'uiSrc/assets/img/modules/RedisAIDark.svg?react' | ||
| import { Icon, IconProps } from 'uiSrc/components/base/icons' | ||
|
|
||
| export const RedisAIDarkIcon = (props: IconProps) => ( | ||
| <Icon icon={RedisAIDark} {...props} /> |
There was a problem hiding this comment.
it's generally more maintainable to have a single reusable Icon component instead of {iconsCount} wrapper components
my suggestion would obviously require reverting lots of changes and making the PR smaller
There was a problem hiding this comment.
It is a single reusble component. The Icon component is the component, that wraps SVG's
If you suggest a component like EuiIcon to which you pass a string which indicates what icon do you want, then I have to disagree.
This approach requires the "MAIN ICON" component to import ALL svgs and map them to strings which one can then use. Which means that importing even a single icon will import them all in any bundle chunk
KIvanow
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.