Feature/ri 7091 add an environment variable to skip the eula screen

redisinsight/api/src/constants/agreements-spec.json

@@ -7,6 +7,7 @@
       "required": false,
       "editable": true,
       "disabled": false,
+      "linkToPrivacyPolicy": true,
       "category": "privacy",
       "since": "1.0.1",
       "title": "Usage Data",
@@ -19,6 +20,7 @@
       "required": false,
       "editable": true,
       "disabled": false,
+      "linkToPrivacyPolicy": false,
       "category": "notifications",
       "since": "1.0.6",
       "title": "Notification",
@@ -37,6 +39,7 @@
           "required": false,
           "editable": true,
           "disabled": false,
+          "linkToPrivacyPolicy": false,
           "category": "privacy",
           "since": "1.0.3",
           "title": "Encryption",
@@ -49,6 +52,7 @@
           "required": false,
           "editable": true,
           "disabled": true,
+          "linkToPrivacyPolicy": false,
           "category": "privacy",
           "since": "1.0.3",
           "title": "Encryption",
@@ -61,6 +65,7 @@
           "required": false,
           "editable": true,
           "disabled": true,
+          "linkToPrivacyPolicy": false,
           "category": "privacy",
           "since": "1.0.5",
           "title": "Encryption",
@@ -75,6 +80,7 @@
       "required": true,
       "editable": false,
       "disabled": false,
+      "linkToPrivacyPolicy": false,
       "since": "1.0.4",
       "title": "Server Side Public License",
       "label": "I have read and understood the Terms",

redisinsight/api/src/modules/database-discovery/local.database-discovery.service.ts

@@ -26,7 +26,7 @@ export class LocalDatabaseDiscoveryService extends DatabaseDiscoveryService {
     firstRun?: boolean,
   ): Promise<void> {
     try {
-      // no need to auto discover for Redis Stack
+      // No need to auto discover for Redis Stack - quick check
       if (SERVER_CONFIG.buildType === 'REDIS_STACK') {
         return;
       }

redisinsight/api/src/modules/encryption/encryption.service.spec.ts

@@ -103,6 +103,44 @@ describe('EncryptionService', () => {
     });
   });
 
+  describe('isEncryptionAvailable', () => {
+    it('should return true when multiple strategies are available (KEYTAR and PLAIN)', async () => {
+      keytarEncryptionStrategy.isAvailable.mockResolvedValueOnce(true);
+      keyEncryptionStrategy.isAvailable.mockResolvedValueOnce(false);
+
+      const result = await service.isEncryptionAvailable();
+
+      expect(result).toBe(true);
+    });
+
+    it('should return true when multiple strategies are available (KEY and PLAIN)', async () => {
+      keytarEncryptionStrategy.isAvailable.mockResolvedValueOnce(false);
+      keyEncryptionStrategy.isAvailable.mockResolvedValueOnce(true);
+
+      const result = await service.isEncryptionAvailable();
+
+      expect(result).toBe(true);
+    });
+
+    it('should return true when all strategies are available (KEY, KEYTAR and PLAIN)', async () => {
+      keytarEncryptionStrategy.isAvailable.mockResolvedValueOnce(true);
+      keyEncryptionStrategy.isAvailable.mockResolvedValueOnce(true);
+
+      const result = await service.isEncryptionAvailable();
+
+      expect(result).toBe(true);
+    });
+
+    it('should return false when only PLAIN strategy is available', async () => {
+      keytarEncryptionStrategy.isAvailable.mockResolvedValueOnce(false);
+      keyEncryptionStrategy.isAvailable.mockResolvedValueOnce(false);
+
+      const result = await service.isEncryptionAvailable();
+
+      expect(result).toBe(false);
+    });
+  });
+
   describe('getEncryptionStrategy', () => {
     it('Should return KEYTAR strategy based on app agreements', async () => {
       expect(await service.getEncryptionStrategy()).toEqual(

redisinsight/api/src/modules/init/local.init.service.ts

@@ -32,7 +32,7 @@ export class LocalInitService extends InitService {
     await this.initAnalytics(firstStart);
     await this.featureService.recalculateFeatureFlags(sessionMetadata);
     await this.redisClientFactory.init();
-    await this.databaseDiscoveryService.discover(sessionMetadata);
+    await this.databaseDiscoveryService.discover(sessionMetadata, firstStart);
   }
 
   async initAnalytics(firstStart: boolean) {

redisinsight/api/src/modules/settings/repositories/local.agreements.repository.spec.ts

@@ -57,6 +57,54 @@ describe('LocalAgreementsRepository', () => {
         data: undefined,
       });
     });
+    it('should create new agreements when entity exists but has no data', async () => {
+      // Mock an entity that exists but has no data property
+      const entityWithoutData = Object.assign(new AgreementsEntity(), {
+        id: mockUserId,
+        version: '1.0.0',
+        data: undefined, // This should trigger the !entity?.data check
+      });
+
+      repository.findOneBy.mockResolvedValueOnce(entityWithoutData);
+
+      const result = await service.getOrCreate(mockSessionMetadata);
+
+      // Verify that save was called to create a new entity
+      expect(repository.save).toHaveBeenCalledWith({
+        id: 1,
+        data: undefined,
+      });
+
+      expect(result).toEqual({
+        ...mockAgreements,
+        version: undefined,
+        data: undefined,
+      });
+    });
+    it('should create new agreements when entity exists but has empty string data', async () => {
+      // Mock an entity that exists but has empty string data
+      const entityWithEmptyData = Object.assign(new AgreementsEntity(), {
+        id: mockUserId,
+        version: '1.0.0',
+        data: '', // This should also trigger the !entity?.data check
+      });
+
+      repository.findOneBy.mockResolvedValueOnce(entityWithEmptyData);
+
+      const result = await service.getOrCreate(mockSessionMetadata);
+
+      // Verify that save was called to create a new entity
+      expect(repository.save).toHaveBeenCalledWith({
+        id: 1,
+        data: undefined,
+      });
+
+      expect(result).toEqual({
+        ...mockAgreements,
+        version: undefined,
+        data: undefined,
+      });
+    });
     it('should fail to create with unique constraint and return existing', async () => {
       repository.findOneBy.mockResolvedValueOnce(null);
       repository.findOneBy.mockResolvedValueOnce(mockAgreements);

redisinsight/api/src/modules/settings/repositories/local.agreements.repository.ts

@@ -17,10 +17,10 @@ export class LocalAgreementsRepository extends AgreementsRepository {
 
   async getOrCreate(
     sessionMetadata: SessionMetadata,
-    defaultOptions: DefaultAgreementsOptions = {}
+    defaultOptions: DefaultAgreementsOptions = {},
   ): Promise<Agreements> {
     let entity = await this.repository.findOneBy({});
-    if (!entity) {
+    if (!entity?.data) {
       try {
         entity = await this.repository.save(
           classToClass(AgreementsEntity, plainToInstance(Agreements, {

redisinsight/api/src/modules/settings/settings.service.ts

@@ -64,7 +64,7 @@ export class SettingsService {
 
       let defaultOptions: object;
       if (SERVER_CONFIG.acceptTermsAndConditions) {
-        const isEncryptionAvailable = await this.encryptionService.isEncryptionAvailable();          
+        const isEncryptionAvailable = await this.encryptionService.isEncryptionAvailable();
 
         defaultOptions = {
           data: {
@@ -84,7 +84,6 @@ export class SettingsService {
         sessionMetadata,
       );
 
-
       return classToClass(GetAppSettingsResponse, {
         ...settings?.data,
         acceptTermsAndConditionsOverwritten: SERVER_CONFIG.acceptTermsAndConditions,

redisinsight/api/test/api/settings/GET-settings-agreements-spec.test.ts

@@ -17,6 +17,7 @@ const agreementItemSchema = Joi.object().keys({
   category: Joi.string().optional(),
   description: Joi.string().optional(),
   requiredText: Joi.string().optional(),
+  linkToPrivacyPolicy: Joi.boolean().required(),
 });
 
 const responseSchema = Joi.object()

redisinsight/ui/src/components/consents-settings/ConsentOption/ConsentOption.spec.tsx

@@ -0,0 +1,126 @@
+import React from 'react'
+import { render, screen, fireEvent } from 'uiSrc/utils/test-utils'
+import ConsentOption from './ConsentOption'
+import { IConsent } from '../ConsentsSettings'
+
+const mockConsent: IConsent = {
+  agreementName: 'analytics',
+  title: 'Analytics',
+  label: 'Share usage data',
+  description: 'Help us improve Redis Insight by sharing usage data.',
+  required: false,
+  editable: true,
+  disabled: false,
+  defaultValue: false,
+  displayInSetting: true,
+  since: '1.0.0',
+  linkToPrivacyPolicy: false,
+}
+
+const mockOnChangeAgreement = jest.fn()
+
+const defaultProps = {
+  consent: mockConsent,
+  onChangeAgreement: mockOnChangeAgreement,
+  checked: false,
+}
+
+describe('ConsentOption', () => {
+  beforeEach(() => {
+    jest.clearAllMocks()
+  })
+
+  it('should render', () => {
+    expect(render(<ConsentOption {...defaultProps} />)).toBeTruthy()
+  })
+
+  it('should render switch with correct test id', () => {
+    render(<ConsentOption {...defaultProps} />)
+    expect(screen.getByTestId('switch-option-analytics')).toBeInTheDocument()
+  })
+
+  it('should call onChangeAgreement when switch is clicked', () => {
+    render(<ConsentOption {...defaultProps} />)
+
+    fireEvent.click(screen.getByTestId('switch-option-analytics'))
+
+    expect(mockOnChangeAgreement).toHaveBeenCalledWith(true, 'analytics')
+  })
+
+  it('should render description without privacy policy link when linkToPrivacyPolicy is false', () => {
+    const consentWithDescription = {
+      ...mockConsent,
+      description: 'Help us improve Redis Insight by sharing usage data.',
+      linkToPrivacyPolicy: false,
+    }
+
+    render(<ConsentOption {...defaultProps} consent={consentWithDescription} />)
+
+    expect(screen.getByText('Help us improve Redis Insight by sharing usage data.')).toBeInTheDocument()
+    expect(screen.queryByText('Privacy Policy')).not.toBeInTheDocument()
+  })
+
+  it('should render description with privacy policy link when linkToPrivacyPolicy is true', () => {
+    const consentWithPrivacyLink = {
+      ...mockConsent,
+      description: 'Help us improve Redis Insight by sharing usage data.',
+      linkToPrivacyPolicy: true,
+    }
+
+    render(<ConsentOption {...defaultProps} consent={consentWithPrivacyLink} />)
+
+    // Verify that the Privacy Policy link is rendered
+    expect(screen.getByText('Privacy Policy')).toBeInTheDocument()
+
+    const privacyPolicyLink = screen.getByText('Privacy Policy')
+    expect(privacyPolicyLink.closest('a')).toHaveAttribute(
+      'href',
+      'https://redis.io/legal/privacy-policy/?utm_source=redisinsight&utm_medium=app&utm_campaign=telemetry'
+    )
+  })
+
+  it('should render description with privacy policy link on settings page when linkToPrivacyPolicy is true', () => {
+    const consentWithPrivacyLink = {
+      ...mockConsent,
+      description: 'Help us improve Redis Insight by sharing usage data.',
+      linkToPrivacyPolicy: true,
+    }
+
+    render(<ConsentOption {...defaultProps} consent={consentWithPrivacyLink} isSettingsPage />)
+
+    // Verify that the Privacy Policy link is rendered
+    expect(screen.getByText('Privacy Policy')).toBeInTheDocument()
+  })
+
+  it('should not render privacy policy link on settings page when linkToPrivacyPolicy is false', () => {
+    const consentWithoutPrivacyLink = {
+      ...mockConsent,
+      description: 'Help us improve Redis Insight by sharing usage data.',
+      linkToPrivacyPolicy: false,
+    }
+
+    render(<ConsentOption {...defaultProps} consent={consentWithoutPrivacyLink} isSettingsPage />)
+
+    expect(screen.getByText('Help us improve Redis Insight by sharing usage data.')).toBeInTheDocument()
+    expect(screen.queryByText('Privacy Policy')).not.toBeInTheDocument()
+  })
+
+  it('should render disabled switch when consent is disabled', () => {
+    const disabledConsent = {
+      ...mockConsent,
+      disabled: true,
+    }
+
+    render(<ConsentOption {...defaultProps} consent={disabledConsent} />)
+
+    const switchElement = screen.getByTestId('switch-option-analytics')
+    expect(switchElement).toBeDisabled()
+  })
+
+  it('should render checked switch when checked prop is true', () => {
+    render(<ConsentOption {...defaultProps} checked />)
+
+    const switchElement = screen.getByTestId('switch-option-analytics')
+    expect(switchElement).toBeChecked()
+  })
+})

redisinsight/ui/src/components/consents-settings/ConsentOption/ConsentOption.tsx

@@ -15,7 +15,6 @@ interface Props {
   checked: boolean
   isSettingsPage?: boolean
   withoutSpacer?: boolean
-  linkToPrivacyPolicy?: boolean
 }
 
 const ConsentOption = (props: Props) => {
@@ -25,7 +24,6 @@ const ConsentOption = (props: Props) => {
     checked,
     isSettingsPage = false,
     withoutSpacer = false,
-    linkToPrivacyPolicy = false,
   } = props
 
   return (
@@ -38,7 +36,7 @@ const ConsentOption = (props: Props) => {
             color="subdued"
             style={{ marginTop: '12px' }}
           >
-            <ItemDescription description={consent.description} withLink={linkToPrivacyPolicy} />
+            <ItemDescription description={consent.description} withLink={consent.linkToPrivacyPolicy} />
           </EuiText>
           <Spacer size="m" />
         </>
@@ -66,7 +64,7 @@ const ConsentOption = (props: Props) => {
               color="subdued"
               style={{ marginTop: '12px' }}
             >
-              <ItemDescription description={consent.description} withLink={linkToPrivacyPolicy} />
+              <ItemDescription description={consent.description} withLink={consent.linkToPrivacyPolicy} />
             </EuiText>
           )}
         </FlexItem>

redisinsight/ui/src/components/consents-settings/ConsentsPrivacy/ConsentsPrivacy.tsx

@@ -97,7 +97,6 @@ const ConsentsPrivacy = () => {
             onChangeAgreement={onChangeAgreement}
             isSettingsPage
             key={consent.agreementName}
-            linkToPrivacyPolicy
           />
         ))}
       </div>