e2e - automatically update #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/e2e/package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@types/chance": "1.1.3", | ||
| "@types/edit-json-file": "^1.7.0", |
There was a problem hiding this comment.
Always better to pin the version
Comment on lines
46
to
48
| await t.expect(timestampAfterUpdate).notEql(timestampForEdit); | ||
| await t.expect(cloudTitle).notEql(cloudValueForEdit); | ||
| await t.expect(cloudDescription).notEql(cloudValueForEdit); |
Comment on lines
38
to
48
| const buildFilePathNew = editJsonFile(buildPath); | ||
| const createRedisFilePathNew = editJsonFile(createRedisPath); | ||
| //Check the promo button | ||
| await t.expect(myRedisDatabasePage.promoButton.textContent).notContains(cloudValueForEdit, 'Promo button text is updated'); | ||
| //Check the json files are automatically updated | ||
| const timestampAfterUpdate = await buildFilePathNew.get('timestamp'); | ||
| const cloudTitle = await createRedisFilePathNew.get('cloud.title'); | ||
| const cloudDescription = await createRedisFilePathNew.get('cloud.description'); | ||
| await t.expect(timestampAfterUpdate).notEql(timestampForEdit); | ||
| await t.expect(cloudTitle).notEql(cloudValueForEdit); | ||
| await t.expect(cloudDescription).notEql(cloudValueForEdit); |
There was a problem hiding this comment.
Something here isn't clear enough.
Do the first two lines are apart of the test or pre requisite?
It's hard to understand from reading the code the test case, and I feel that in case the test will be fail, shouldn't be easy understand the bug (and if the bug is on the product or test).
There was a problem hiding this comment.
these first two lines are necessary because the data that is in these files is cached and needs to be overwritten to get the updated information
I also added more comments to this test
ofersteinberg
previously approved these changes
Apr 18, 2022
ofersteinberg
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.