Feature/ Workbench - telemetry events #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
previously approved these changes
Dec 2, 2021
| describe('sendCliClientCreatedEvent', () => { | ||
| it('should emit CliClientCreated event', () => { | ||
| service.sendCliClientCreatedEvent(instanceId, { data: 'Some data' }); | ||
| service.sendClientCreatedEvent(instanceId, 'cli', { data: 'Some data' }); |
There was a problem hiding this comment.
use AppTool.CLI instead of string 'cli'
| describe('sendCliClientCreationFailedEvent', () => { | ||
| it('should emit CliClientCreationFailed event', () => { | ||
| service.sendCliClientCreationFailedEvent(instanceId, httpException, { data: 'Some data' }); | ||
| service.sendClientCreationFailedEvent(instanceId, 'cli', httpException, { data: 'Some data' }); |
| }); | ||
| it('should emit CliClientCreationFailed event without additional data', () => { | ||
| service.sendCliClientCreationFailedEvent(instanceId, httpException); | ||
| service.sendClientCreationFailedEvent(instanceId, 'cli', httpException); |
| describe('sendCliClientRecreatedEvent', () => { | ||
| it('should emit CliClientRecreated event', () => { | ||
| service.sendCliClientRecreatedEvent(instanceId, { data: 'Some data' }); | ||
| service.sendClientRecreatedEvent(instanceId, 'cli', { data: 'Some data' }); |
There was a problem hiding this comment.
Here and everywhere use constants instead of string
| } | ||
| default: | ||
| return `CLI_${event}`; | ||
| } |
There was a problem hiding this comment.
there is no need to duplicate CLI_ prefix in the 'cli' and 'default' cases. Use default only instead
ArtemHoruzhenko
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#RI-1100 - add telemetry events for the workbench