Skip to content

Conversation

valkirilov
Copy link
Member

@valkirilov valkirilov commented Sep 25, 2025

Description

Rework the visuals of the actions button on the Browser page.

  • change the "Bulk Actions" button type
  • remove the "+" icon from the "Add keys" button
Before After
Normal state -
Screenshot 2025-09-25 at 16 23 49 Screenshot 2025-09-26 at 9 24 42
Screenshot 2025-09-25 at 16 23 54 Screenshot 2025-09-26 at 9 27 19
Hover state -
Screenshot 2025-09-25 at 16 23 30 Screenshot 2025-09-26 at 9 27 51
Screenshot 2025-09-25 at 16 23 37 Screenshot 2025-09-26 at 9 27 59

Copy link
Contributor

github-actions bot commented Sep 25, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 82.16% 20007/24351
🟡 Branches 67.55% 8678/12847
🟡 Functions 76.29% 5324/6979
🟢 Lines 82.58% 19587/23718

Test suite run success

5157 tests passing in 677 suites.

Report generated by 🧪jest coverage report action from 83e52f6

dantovska
dantovska previously approved these changes Sep 25, 2025
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that buttons are not aligned vertically

Image

@valkirilov
Copy link
Member Author

valkirilov commented Sep 26, 2025

I can see that buttons are not aligned vertically

Image

This is what I call "sharp eyes", thanks for spotting that!

Edit: After feedback from the Redis UI team, it seems like we shouldn't extend the TextButton to support multiple sizes, so we're going with what we have:

  • vertically center the items between each other
  • align the action buttons with the navigation
image

The issue was caused by the fact that the TextButton (Bulk Actions) wasn't supporting the same sizes as the RegularButton (Add Keys), leading to them both being misaligned.

Redis UI provides a single fixed size for the TextButton, so I had to extend its interface and make it support the same sizes as the rest of the buttons (small, medium, and large). And to keep it consistent, we'll use the same sizes, provided by Redis UI. I hope that one day they may support this behavior by default.

Here is the end result:

Example Guidelines Centered
Screenshot 2025-09-26 at 9 35 07 Screenshot 2025-09-26 at 9 36 07 Screenshot 2025-09-26 at 9 38 27

dantovska
dantovska previously approved these changes Sep 26, 2025
- vertically center the items between each other
- align the action buttons with the navigation

re #RI-7554
Copy link
Collaborator

@ArtemHoruzhenko ArtemHoruzhenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

grow={false}
justify="center"
style={{ paddingTop: '20px' }}
style={{ paddingTop: '16px' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is bugging me, but I guess it should be fixed in dedicated ticket

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix to make the action buttons and the navigation in line.
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the inline style is bugging me, not the value :)

@valkirilov valkirilov merged commit d420f81 into main Sep 29, 2025
18 checks passed
@valkirilov valkirilov deleted the fe/bugfix/RI-7554_browser-bulk-actions branch September 29, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants