RI-7508: get db version from another selector since it might be not a… #4998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtemHoruzhenko
requested review from
KrumTy,
dantovska,
pawelangelow,
pd-redis and
valkirilov
as code owners
valkirilov
approved these changes
Sep 26, 2025
| (): UseRedisInstanceCompatibilityReturn => { | ||
| const { | ||
| version, | ||
| } = useSelector(connectedInstanceInfoSelector) |
There was a problem hiding this comment.
Ouch, this means we have different behavior for what we store in Redux, based on the environment 😔
Do you think that we can get rid of one of the selectors (not now, I'm just asking if you checked what we store in both selectors, and whether it's possible to live only with one of them).
There was a problem hiding this comment.
Something to think about. I'm looking on another solution for this currently. Let see if it will work
Code Coverage - Frontend unit tests
Test suite run success5159 tests passing in 677 suites. Report generated by 🧪jest coverage report action from 1866dd6 |
KrumTy
approved these changes
Sep 29, 2025
ArtemHoruzhenko
deleted the
fe/feature/RI-7508-get-version-from-another-selector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get db version from another selector since it might be not returned by another selector.