RI-7541: Use size m instead of hard coded width and height for the svg #5030
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantovska
requested review from
KrumTy,
pawelangelow,
ArtemHoruzhenko,
pd-redis and
valkirilov
as code owners
valkirilov
approved these changes
Oct 3, 2025
KrumTy
approved these changes
Oct 3, 2025
dantovska
force-pushed
the
fe/bugfix/RI-7541-use-icon-component-size
branch
from
9bfc6ae to
5bf48f8
Compare
pd-redis
approved these changes
Oct 6, 2025
Code Coverage - Frontend unit tests
Test suite run success5162 tests passing in 677 suites. Report generated by 🧪jest coverage report action from 5bf48f8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Redis UI Icon component has a size, the size should be used instead hard coded pixels for the icon svg, where possible.
Almost no visible difference: