Skip to content

e2e - test fixes #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2022
Merged

e2e - test fixes #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
349b2ab
e2e - test fixes
tanyatrayanava May 23, 2022
3bf2317
e2e - remove debug and unskip test
tanyatrayanava May 24, 2022
f15d089
Merge branch 'main' into feature/e2e-test-fixes
tanyatrayanava May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/e2e/pageObjects/browser-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export class BrowserPage {
addNewStreamEntry = Selector('[data-testid=add-key-value-items-btn]');
removeEntryButton = Selector('[data-testid^=remove-entry-button-]');
confirmRemoveEntryButton = Selector('[data-testid^=remove-entry-button-]').withExactText('Remove');
clearStreamEntryInputs = Selector('[data-testid=remove-item]');
//LINKS
internalLinkToWorkbench = Selector('[data-testid=internal-workbench-link]');
//OPTION ELEMENTS
Expand Down Expand Up @@ -110,7 +111,7 @@ export class BrowserPage {
streamEntryId = Selector('[data-testid=entryId]');
streamField = Selector('[data-testid=field-name]');
streamValue = Selector('[data-testid=field-value]');
addStreamRow = Selector('[data-testid=add-new-row]');
addStreamRow = Selector('[data-testid=add-new-item]');
streamFieldsValues = Selector('[data-testid^=stream-entry-field-]');
//TEXT ELEMENTS
keySizeDetails = Selector('[data-testid=key-size-text]');
Expand Down Expand Up @@ -219,14 +220,14 @@ export class BrowserPage {
* @param value The key value
* @param TTL The Time to live value of the key (optional parameter)
*/
async addJsonKey(keyName: string, value = ' ', TTL?: string): Promise<void> {
async addJsonKey(keyName: string, value: string, TTL?: string): Promise<void> {
await t.click(this.plusAddKeyButton);
await t.click(this.keyTypeDropDown);
await t.click(this.jsonOption);
await t.click(this.addKeyNameInput);
await t.typeText(this.addKeyNameInput, keyName);
await t.click(this.jsonKeyValueInput);
await t.typeText(this.jsonKeyValueInput, value);
await t.typeText(this.jsonKeyValueInput, value, { paste: true });
if (TTL !== undefined) {
await t.click(this.keyTTLInput);
await t.typeText(this.keyTTLInput, TTL);
Expand Down
2 changes: 1 addition & 1 deletion ...ritical-path/browser/stream-key.e2e.ts.ts → .../browser/stream-key-entry-deletion.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const values = [
'27'
];

fixture `Stream key`
fixture `Stream key entry deletion`
.meta({
type: 'critical_path',
rte: rte.standalone
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/critical-path/monitor/save-commands.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { rte } from '../../../helpers/constants';
const monitorPage = new MonitorPage();
const cliPage = new CliPage();
const tempDir = os.tmpdir();
const downloadsDir = `${process.env.HOME}\\Downloads`;
const downloadsDir = `C:*****\\Downloads`;

fixture `Save commands`
.meta({ type: 'regression' })
Expand Down
12 changes: 6 additions & 6 deletions tests/e2e/tests/regression/browser/last-refresh.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ test
//Hover on the refresh icon
await t.hover(browserPage.refreshKeysButton);
//Verify the last update info
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nless than a minute ago', 'tooltip text');
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nnow', 'tooltip text');
});
test
.meta({ rte: rte.standalone })
Expand All @@ -43,11 +43,11 @@ test
await t.wait(120000);
//Hover on the refresh icon
await t.hover(browserPage.refreshKeyButton);
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\n2 minutes ago', 'tooltip text');
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\n2 min', 'tooltip text');
//Click on Refresh and check last refresh
await t.click(browserPage.refreshKeyButton);
await t.hover(browserPage.refreshKeyButton);
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nless than a minute ago', 'tooltip text');
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nnow', 'tooltip text');
});
test
.meta({ rte: rte.standalone })
Expand All @@ -59,7 +59,7 @@ test
//Hover on the refresh icon
await t.hover(browserPage.refreshKeyButton);
//Verify the last update info
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nless than a minute ago', 'tooltip text');
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nnow', 'tooltip text');
});
test
.meta({ rte: rte.standalone })
Expand All @@ -71,9 +71,9 @@ test
//Hover on the keys refresh icon
await t.hover(browserPage.refreshKeysButton);
//Verify the last update info
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nless than a minute ago', 'tooltip text');
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nnow', 'tooltip text');
//Hover on the key in details refresh icon
await t.hover(browserPage.refreshKeyButton);
//Verify the last update info
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nless than a minute ago', 'tooltip text');
await t.expect(browserPage.tooltip.innerText).contains('Last Refresh\nnow', 'tooltip text');
});