Skip to content

RI-3011,3009 - remove trash icon, update text #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2022
Merged

RI-3011,3009 - remove trash icon, update text #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c5e05
RI-3011,3009 - remove trash icon, update text
AmirAllayarovSofteq Jun 2, 2022
0156968
#RI-3010 - update message
AmirAllayarovSofteq Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions ...s/browser/components/stream-details/messages-view/MessageAckPopover/MessageAckPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,15 @@ const AckPopover = (props: Props) => {
>
<div className={styles.popover}>
<EuiText size="m">
<EuiText size="s">
Are you sure to acknowledge
{' '}
<b>{id}</b>
?
</EuiText>
This will remove entry from pending list.
<b>{id}</b>
<br />
will be acknowledged and removed from the pending messages list
</EuiText>
<div className={styles.popoverFooter}>
<EuiButton
fill
size="s"
color="warning"
iconType="trash"
onClick={() => acknowledge(id)}
data-testid="acknowledge-submit"
>
Expand Down
2 changes: 1 addition & 1 deletion ...i/src/pages/browser/components/stream-details/messages-view/MessagesView/MessagesView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import styles from './styles.module.scss'
const headerHeight = 60
const rowHeight = 54

const noItemsMessageString = 'There are no Messages in the Consumer Group.'
const noItemsMessageString = 'Your Consumer has no pending messages.'

export interface Props {
data: PendingEntryDto[]
Expand Down