Skip to content

Conversation

ArtyomPSofteq
Copy link
Contributor

refactor events communication between app and plugins

@ArtyomPSofteq
Copy link
Contributor Author

ArtyomPSofteq commented Dec 8, 2021

refactor events communication between app and plugins

I have slightly reworked the event's communication between the plugins and the app. But the plugin still doesn't render when we run e2e tests. @romansergeenkosofteq @zalenskiSofteq Could you please check why the plugin's render method was called but ReactDOM.render isn't working?

@egor-zalenski
Copy link
Contributor

egor-zalenski commented Dec 9, 2021

I have slightly reworked the event's communication between the plugins and the app. But the plugin still doesn't render when we run e2e tests. @romansergeenkosofteq @zalenskiSofteq Could you please check why the plugin's render method was called but ReactDOM.render isn't working?

fixed ReactDOM.render for e2e tests

egor-zalenski
egor-zalenski previously approved these changes Dec 9, 2021
@egor-zalenski egor-zalenski self-assigned this Dec 9, 2021
@ArtyomPSofteq ArtyomPSofteq merged commit 42a3c1d into main Dec 9, 2021
@ArtyomPSofteq ArtyomPSofteq deleted the fix/testcafe-workbench-plugins branch December 9, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants