Skip to content

#RI-3292, #RI-3287, #RI-3288 #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2022
Merged

#RI-3292, #RI-3287, #RI-3288 #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04626de
* #RI-3292 - Error messages overlappses if key name is too long
egor-zalenski Jul 18, 2022
c2e24e3
* #RI-3288 - No new keys in Tree view after Scan more
egor-zalenski Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion redisinsight/ui/src/components/virtual-tree/components/Node/Node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react'
import React, { useEffect } from 'react'
import { NodePublicState } from 'react-vtree/dist/es/Tree'
import cx from 'classnames'
import { EuiIcon, EuiToolTip, keys as ElasticKeys } from '@elastic/eui'
Expand Down Expand Up @@ -31,6 +31,12 @@ const Node = ({
updateStatusSelected,
} = data

useEffect(() => {
if (isSelected && keys) {
updateStatusSelected?.(fullName, keys)
}
}, [keys, isSelected])

const handleClick = () => {
if (isLeaf && keys) {
setItems?.(keys)
Expand Down
6 changes: 4 additions & 2 deletions .../pages/browser/components/bulk-actions/BulkDelete/BulkDeleteContent/BulkDeleteContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,10 @@ const BulkDeleteContent = () => {

return (
<div style={style} className={styles.item} data-testid={`row-${index}`}>
<div color="subdued" className={styles.key}>{key}</div>
<div ref={rowRef} className={styles.error}>{error}</div>
<span ref={rowRef}>
<span className={styles.key}>{key}</span>
<span className={styles.error}>{error}</span>
</span>
</div>
)
}
Expand Down
1 change: 0 additions & 1 deletion redisinsight/ui/src/pages/browser/components/keys-header/KeysHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ const KeysHeader = (props: Props) => {
}
})
}
dispatch(resetKeys())
dispatch(resetKeysData())
dispatch(changeKeyViewType(type))
dispatch(resetBrowserTree())
Expand Down