tests for improve eula screen feature #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-dargel
changed the title
Comment on lines
48
to
57
| async getAnalyticsSwitcherValue(): Promise<string> { | ||
| return await this.switchAnalyticsOption.getAttribute('aria-checked'); | ||
| } | ||
|
|
||
| async getNotificationsSwitcherValue(): Promise<string> { | ||
| return await this.switchNovitifationsOption.getAttribute('aria-checked'); | ||
| } | ||
|
|
||
| async getEulaSwitcherValue(): Promise<string> { | ||
| return await this.switchEulaOption.getAttribute('aria-checked'); |
| } | ||
| } | ||
|
|
||
| async getRecommendedSwitcherValue(): Promise<string> { |
| await t.click(addRedisDatabasePage.addDatabaseButton); | ||
| await t.expect(addRedisDatabasePage.addDatabaseManually.exists).ok('User can add a database'); | ||
| }); | ||
| test('Verify that user should accept User Agreements to continue working with the application, the Welcome page is opened after user agrees, the encryption enabled by default and specific message', async t => { |
| await t.click(addRedisDatabasePage.addDatabaseButton); | ||
| await t.expect(addRedisDatabasePage.addDatabaseManually.exists).ok('User can add a database'); | ||
| }); | ||
| test('Verify that user should accept User Agreements to continue working with the application, the Welcome page is opened after user agrees, the encryption enabled by default and specific message', async t => { |
There was a problem hiding this comment.
@ViktarStarastsenka - This isn't e2e, it has to be covered in JEST as many tests cases
There was a problem hiding this comment.
It's not my test, but ok, I'll update it
| await t.expect(userAgreementPage.pluginSectionWithText.visible).ok('Plugin text is displayed'); | ||
| //Verify that text that is displayed in window is 'While adding new visualization plugins, use files only from trusted authors to avoid automatic execution of malicious code.' | ||
| const pluginText = userAgreementPage.pluginSectionWithText.innerText; | ||
| await t.expect(pluginText).eql('To avoid automatic execution of malicious code, when adding new Workbench plugins, use files from trusted authors only.'); |
ofersteinberg
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.