E2E test with Shortcuts is added #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
22
to
26
| this.helpCenterSubmitBugButton = Selector('[data-testid="submit-bug-btn"]'); | ||
| this.helpCenterShortcutButton = Selector('[data-testid="shortcuts-btn"]'); | ||
| this.helpCenterReleaseNotesButton = Selector('[data-testid="release-notes-btn"]'); | ||
| // Panel | ||
| this.helpCenterPanel = Selector('[data-testid="help-center"]') |
There was a problem hiding this comment.
The " within the data-testid are not required.
There was a problem hiding this comment.
Removed quotes for 2 files for all selectors except shortcutsDesktopApplicationSection (since it is contains space and doesn't work without quotes).
ofersteinberg
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New e2e test with shortcuts page is added