Skip to content

Langcache: Change examples from multitab to local client examples #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025

Conversation

cmilesb
Copy link
Contributor

@cmilesb cmilesb commented Jul 31, 2025

Also adds a "footer=hide" option to the client examples to hide the footer, since I couldn't figure out how to hide the footer for specific tabs.

@cmilesb cmilesb requested review from andy-stark-redis and a team July 31, 2025 19:05
@cmilesb cmilesb self-assigned this Jul 31, 2025
Copy link
Contributor

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wouldn't hurt to have @andy-stark-redis look at the changes as well. That is, if you can wait until tomorrow.

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


```bash
curl -s -X POST "https://$HOST/v1/caches/$CACHE_ID/entires/search" \
{{< clients-example set="langcache_sdk" step="imports_setup" dft_tab_name="cURL" footer="hide" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution is fine, but just a thought about an alternative: you can override the default tab footer link too, so you could maybe link to the example here? I guess there's no limit to the number of named parameters now, so perhaps there's a way to override the footer link for each language if the quickstart link is a problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the quickstart links are the issue. It would be better if I could override all of the links or disable just the quickstart links. As it stands right now, I'm fine with hiding the footer entirely.

@cmilesb cmilesb merged commit 51fc7d8 into main Aug 1, 2025
5 checks passed
@cmilesb cmilesb deleted the langcache-tces branch August 1, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants