-
Notifications
You must be signed in to change notification settings - Fork 261
DEV: add TCEs to EXISTS command #2036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Staging links: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shaping up really well! The code basically looks OK and I compiled and ran a few of the files and they worked fine. The main issue is the test suite stuff that appears in the original sources, but gets extracted from the examples.
A few thoughts:
- Just out of interest, did you refer
Augi...Augment to the examples on the website or to the examples in the client repos for the languages? I've found it tends to do better when you explicitly say "look at the examples indoctests
", but the downside is that you might have to do this separately for each language, which I guess is not the goal here. - I'd be interested to know if you selected Claude or GPT5 for this. I'm still trying to get an impression of both but Claude seems faster and tries to be "fun" (emojis and 'You're absolutely right!", etc), while GPT is slower and boring but seems to think more deeply about what it's doing. Claude might actually be better for short snippets like the ones in the command pages.
- I don't know if you are using Enhance Prompt, but when you do, it usually gives you a list of requirements for the conversion. It's then quite easy to add your own short directions and reminders to the list ("convert all the examples, not just some of them", "translate the tests as well as the snippets", etc).
Really good, though - great bit of exploration here :-)
Hi @andy-stark-redis. I manually restructured the invalid examples using code I found in other examples. I'm still not set up to test C#, GO, Java/Lettuce, and PHP, so this is a Hail Mary pass. When you have time, would you please take a look? |
This is really getting somewhere now :-) Still a few minor glitches, but easy to fix and you'd expect them to disappear as we add more of these examples for it to use as a reference. I'd say it would be more or less OK to use now, as long as we are careful about checking the output and fixing it (but we are expecting to have to do that anyway, right?) Summary is below: NRedisStack: looks fine. Predis: go-redis: Jedis: looks fine. Lettuce-async: Lettuce-reactive: |
Thanks again, @andy-stark-redis. I've patched up those issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I've approved but I guess we should add PRs for these to the respective client repos and see what the CI says?
I have 11 more commands to do in this quarter's batch, and I thought I'd submit them to the client repos en masse. That said, I'm flexible. |
@dwdougherty Batch is fine by me :-) |
Hi @andy-stark-redis. This PR is an experiment to see if Augment can successfully create TCEs in all currently supported languages. At some point, the examples in the
local_examples/cmd_exists/LANG
directories can become PRs for each LANG's repo.I don't have the correct system setup to test each of these; hoping you help here (at some point--no rush). Maybe you can just advise on setup so I can test new examples myself.