Skip to content

Conversation

andy-stark-redis
Copy link
Contributor

All feedback welcome on this rather complicated page, including:

  • Is it too long? Maybe some of the content could be moved elsewhere.
  • Do the diagrams make sense?
  • Is the basic breakdown of presentation OK?

@andy-stark-redis andy-stark-redis requested a review from a team September 2, 2025 15:19
@andy-stark-redis andy-stark-redis self-assigned this Sep 2, 2025
@andy-stark-redis andy-stark-redis added the clients Client library docs label Sep 2, 2025
Copy link
Contributor

github-actions bot commented Sep 2, 2025

DOC-5665

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Answers to your questions:

  • Is it too long? Maybe some of the content could be moved elsewhere. [DWD] I think it's good that it's all grouped together; not obvious how you could split this up.
  • Do the diagrams make sense? [DWD] Yes.
  • Is the basic breakdown of presentation OK? [DWD] Yes.

@andy-stark-redis
Copy link
Contributor Author

Thanks @dwdougherty ! As regards splitting it up, I was wondering if we should have a page for the concepts, a bit like we do for client-side caching. Might make more sense to wait until some of the other clients support failover before doing that, though.

@dwdougherty
Copy link
Collaborator

Ah... it wasn't clear to me that other clients would support this functionality. If that's the case, then maybe splitting the content into concepts and per-client implementation sections would probably make sense. Though, I think you're right about keeping it intact until other clients add support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients Client library docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants