-
Notifications
You must be signed in to change notification settings - Fork 254
DOC-5665 Jedis failover docs #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Answers to your questions:
- Is it too long? Maybe some of the content could be moved elsewhere. [DWD] I think it's good that it's all grouped together; not obvious how you could split this up.
- Do the diagrams make sense? [DWD] Yes.
- Is the basic breakdown of presentation OK? [DWD] Yes.
Thanks @dwdougherty ! As regards splitting it up, I was wondering if we should have a page for the concepts, a bit like we do for client-side caching. Might make more sense to wait until some of the other clients support failover before doing that, though. |
Ah... it wasn't clear to me that other clients would support this functionality. If that's the case, then maybe splitting the content into concepts and per-client implementation sections would probably make sense. Though, I think you're right about keeping it intact until other clients add support. |
All feedback welcome on this rather complicated page, including: