Skip to content

Conversation

andy-stark-redis
Copy link
Contributor

Examples for the new BITOP commands (and some of the old ones) along with new bitmap data type examples for the clients that didn't already have any.

@andy-stark-redis andy-stark-redis requested a review from a team September 22, 2025 15:46
@andy-stark-redis andy-stark-redis self-assigned this Sep 22, 2025
@andy-stark-redis andy-stark-redis added the clients Client library docs label Sep 22, 2025
Copy link
Contributor

github-actions bot commented Sep 22, 2025

DOC-5743

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the one janky link highlighted below, the C# examples all show just one comment line. Looks like that was done intentionally. Maybe just don't show those?

Co-authored-by: David Dougherty <david.dougherty@redis.com>
@andy-stark-redis
Copy link
Contributor Author

andy-stark-redis commented Sep 23, 2025

In addition to the one janky link highlighted below, the C# examples all show just one comment line. Looks like that was done intentionally. Maybe just don't show those?

@dwdougherty I've fixed the dodgy URL - thanks for spotting that (the dodgy version works on the local test build, strangely).

The C# examples intentionally show that the bitops aren't supported. NRedisStack does support getbit/setbit and bitcount, though, which is why we have C# examples for this. We can choose any subset of examples to show, so we could just avoid showing the C# ones for the unsupported commands. However, my thinking was that because there is partial support for bitmaps, it might be best to use the comments to state explicitly what is not supported.

Anyway, if you think the C# comments are redundant or misleading then I'll remove them.

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. You've handled the missing features the way we've discussed previously. My rotting brain just forgot.

@andy-stark-redis
Copy link
Contributor Author

@dwdougherty Thanks for the review!

@andy-stark-redis andy-stark-redis merged commit 2f8764d into main Sep 23, 2025
5 checks passed
@andy-stark-redis andy-stark-redis deleted the DOC-5743-bitops-examples branch September 23, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients Client library docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants