-
Notifications
You must be signed in to change notification settings - Fork 258
DOC-5743 bitops examples #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-5743 bitops examples #2158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the one janky link highlighted below, the C# examples all show just one comment line. Looks like that was done intentionally. Maybe just don't show those?
Co-authored-by: David Dougherty <david.dougherty@redis.com>
@dwdougherty I've fixed the dodgy URL - thanks for spotting that (the dodgy version works on the local test build, strangely). The C# examples intentionally show that the bitops aren't supported. NRedisStack does support Anyway, if you think the C# comments are redundant or misleading then I'll remove them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. You've handled the missing features the way we've discussed previously. My rotting brain just forgot.
@dwdougherty Thanks for the review! |
Examples for the new
BITOP
commands (and some of the old ones) along with new bitmap data type examples for the clients that didn't already have any.