Skip to content

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Sep 30, 2025

All tests were run locally and passed. The predis example is a bit different than the others: it has setup and teardown methods, and some different imports, etc.

I added the full suite of existing hash tests to the lettuce-async and lettuce-reactive examples.

No rust examples yet.

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Sep 30, 2025

DOC-5632

Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because the code examples are there and look good, but I did notice that the copy and view examples buttons cover the language selection in some cases. Probably not something to fix as part of this, though.

Image

@dwdougherty
Copy link
Collaborator Author

Approving because the code examples are there and look good, but I did notice that the copy and view examples buttons cover the language selection in some cases. Probably not something to fix as part of this, though.

Thank you for the review, @cmilesb! Andy and I have started a discussion about the tabs. Andy just added two more tab types (rust-sync and rust-async), so the example panes are going to be even more weird and squished when we start adding those examples. 😧

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the PHP thing (easily fixed), this basically LGTM. It will need testing, but probably makes sense to wait until you've added all your planned changes to this file before running tests and submitting PRs to the client repos.

Very impressive that you've got the full set of languages in place right from the start :-)

Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
@dwdougherty
Copy link
Collaborator Author

Thanks, @andy-stark-redis! BTW, I did test everything locally. Augment helped me get everything set up on my MacBook so I can test all new examples going forward.

@dwdougherty dwdougherty merged commit 11e069e into main Oct 1, 2025
8 checks passed
@dwdougherty dwdougherty deleted the DOC-5632 branch October 1, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants