-
Notifications
You must be signed in to change notification settings - Fork 261
DEV: add TCEs to HDEL command page #2191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Staging links: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review, @cmilesb! Andy and I have started a discussion about the tabs. Andy just added two more tab types (rust-sync and rust-async), so the example panes are going to be even more weird and squished when we start adding those examples. 😧 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the PHP thing (easily fixed), this basically LGTM. It will need testing, but probably makes sense to wait until you've added all your planned changes to this file before running tests and submitting PRs to the client repos.
Very impressive that you've got the full set of languages in place right from the start :-)
Co-authored-by: andy-stark-redis <164213578+andy-stark-redis@users.noreply.github.com>
Thanks, @andy-stark-redis! BTW, I did test everything locally. Augment helped me get everything set up on my MacBook so I can test all new examples going forward. |
All tests were run locally and passed. The predis example is a bit different than the others: it has setup and teardown methods, and some different imports, etc.
I added the full suite of existing hash tests to the lettuce-async and lettuce-reactive examples.
No rust examples yet.